-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopped working with vue-tsc 2.0.1 #306
Comments
There's been a breaking change since vue-tsc@2. I took a look into the code and found that it's impossible to use the former method to integrate with vue-tsc 🥲. Some brief conditions:
|
Maybe pin this issue? |
|
@fi3ework I don't know exactly how |
I used |
@netroy define "fixed the issue"? If it builds, but doesn't actually report the problems anymore when there are some, it's not a fix. To me it did not report (at least all; if any) issues in the code. |
@netroy did you run This is index 4476f608f93257896c67e0fa525562433733a87c..aaea600badc20dc11cee87deac2f9554abf16fc9 100644
--- a/dist/cjs/checkers/vueTsc/prepareVueTsc.js
+++ b/dist/cjs/checkers/vueTsc/prepareVueTsc.js
@@ -42,7 +42,7 @@ const { copy, mkdir } = import_fs_extra.default;
const _require = (0, import_module.createRequire)(importMetaUrl);
const _filename = (0, import_url.fileURLToPath)(importMetaUrl);
const _dirname = (0, import_path.dirname)(_filename);
-const proxyApiPath = _require.resolve("vue-tsc/out/index");
+const proxyApiPath = _require.resolve("vue-tsc/index");
async function prepareVueTsc() {
const targetTsDir = import_path.default.resolve(_dirname, "typescript-vue-tsc");
const vueTscFlagFile = import_path.default.resolve(targetTsDir, "vue-tsc-resolve-path");
diff --git a/dist/esm/checkers/vueTsc/prepareVueTsc.js b/dist/esm/checkers/vueTsc/prepareVueTsc.js
index 94334b8862feddf28cf32cad5a67112eb3a58cec..f5693c9b8ec1b74e54cb18c9ba72bac3b761d231 100644
--- a/dist/esm/checkers/vueTsc/prepareVueTsc.js
+++ b/dist/esm/checkers/vueTsc/prepareVueTsc.js
@@ -8,7 +8,7 @@ const { copy, mkdir } = fsExtra;
const _require = createRequire(import.meta.url);
const _filename = fileURLToPath(import.meta.url);
const _dirname = dirname(_filename);
-const proxyApiPath = _require.resolve("vue-tsc/out/index");
+const proxyApiPath = _require.resolve("vue-tsc/index");
async function prepareVueTsc() {
const targetTsDir = path.resolve(_dirname, "typescript-vue-tsc");
const vueTscFlagFile = path.resolve(targetTsDir, "vue-tsc-resolve-path"); As the author said, there are breaking changes in |
same error |
@johnsoncodehk @fi3ework is there any chance this will be upgraded? |
* vue-tsc は以下の問題により v1 系を使用 ``` You may experience issues with the latest vue-tsc and vite-plugin-checker, used internally when type checking. For now, you may need to stay on v1 of vue-tsc, and follow these upstream issues for updates: fi3ework/vite-plugin-checker#306 and vuejs/language-tools#3969. ``` https://nuxt.com/docs/guide/concepts/typescript#type-checking
Patching Patch for reference:
|
Bump:
This has been broken for many months now and is blocking an entire framework from moving forward |
@LTo666 I'm afraid it's still not related to this issue in any way. You're better off creating a new one. |
関連のIssue: fi3ework/vite-plugin-checker#306 (comment) vuejs/language-tools#4484 一時的な回避案で、正式な修正は`vite-plugin-checker`のvue-tsc v2.x対応待ち fi3ework/vite-plugin-checker#327
Is this issue fixed or why has it been closed? |
It's been fixed with #327. |
If you could take a min of your time to see the commits you will know. |
Released in 0.7.0. Kudos to @so1ve making this happen. |
@fi3ework , very much thank you for making the release happen which I've been eagerly looking forward to. However, I've upgraded to vite-plugin-checker 0.7.0 with vue-tsc 2.0.24 (here's my package.json). This is my vite.config.ts. When I run
|
I had the same issue and resolved it by upgrading typescript to the latest version 5.5.2 |
@topvis @yeongsheng-tan could you provide a minimal repro? |
@fi3ework here's our github repo, and the frontend code is in the sub-dir |
As I said in my previous reply, the issue was resolved by upgrading typescript to the latest version. I remember it's actually a vue-tsc issue instead of this lib's. |
Indeed. @topvis, I upgraded from [email protected] to 5.5.2 and it solved the issue above. Is this something you are aware of and we need to ensure in our package.json @fi3ework ? |
We should add a TS version check for vue-tsc. For now, vue-tsc only works with TS5 https://vite-plugin-checker.netlify.app/checkers/vue-tsc.html#installation. |
I had version 5.4.5 of typescript installed. That version is having the same error |
You'll need to upgrade to TS version 5.5.x (I think current latest is 5.5.3). |
I speculate that each version of vue-tsc has different minimum TypeScript version requirements. |
After upgrading TS, new errors: |
This has been raised in vuejs/language-tools#4755 and #395 |
Describe the bug
Since file structuring changed in vue-tsc 2+, checker plugin no longer works as it expects file being in the exact location:
Reproduction
Install checker plugin, vue-tsc 2.0.1 and enable vueTsc checker.
Expected behavior
Plugin works.
System Info
N/A. Sorry, filling this issue on my phone since I've noticed the issue in my CI build after dependabot update.
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: