Add certificate renewal cooloff period (continued) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fffonion
reviewed
Aug 9, 2021
fffonion
reviewed
Aug 9, 2021
fffonion
reviewed
Aug 9, 2021
|
Thanks @kfigiela ,looks good to me overall, I left several minor comments. |
|
Applied review remarks, please review. |
|
@fffonion HI ! Would you consider merging this PR, we could use the upstream version :) |
fffonion
added a commit
that referenced
this pull request
Apr 8, 2022
From #46 Co-authored-by: Kamil Figiela <[email protected]>
|
manually merged, will release new version : ) |
|
🙇 |
|
#26 can likely be closed as well |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes #26 to fix #20.