Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook or configurable cool off when generation fails #20

Closed
cdloh opened this issue Dec 1, 2020 · 3 comments
Closed

Add hook or configurable cool off when generation fails #20

cdloh opened this issue Dec 1, 2020 · 3 comments
Labels
enhancement New feature or request work in progress

Comments

@cdloh
Copy link
Contributor

cdloh commented Dec 1, 2020

Would it be possible to add a hook or something along those lines for a user supplied function for when certification generation fails.

The problem I'm trying to solve is that the application that sits behind openresty is configurable to have any user supplied domain. We then gather those domains and add them to the whitelist used by resty acme.

However there are times that those domains either aren't publicly available or resolvable.

My thoughts are that if we had a user configurable function that could be used on certification creation failure user supplied code could then handle these situations, or adding a configurable cool down period so that acme doesn't keep trying to generate a failed certificate.

@fffonion fffonion added the enhancement New feature or request label Dec 1, 2020
@cdloh
Copy link
Contributor Author

cdloh commented Dec 3, 2020

@fffonion would you be happy to accept an MR on this? Do you have any thoughts either way?

@fffonion
Copy link
Owner

fffonion commented Dec 3, 2020

@cdloh Yes PRs are welcomed! I recently developed a similar feature in Kong ACME plugin (https://github.com/Kong/kong-plugin-acme/blob/master/kong/plugins/acme/client.lua#L229). I think for now a per domain cool down time will be sufficient as that's most people hit rate limit with. Basically you configure a backoff time (like 5 minutes), and remember that on a per domain basis in the storage.

@fffonion
Copy link
Owner

fffonion commented Apr 8, 2022

Fixed by #46 / #59

@fffonion fffonion closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants