SurfaceKinetics demo #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
- I realise we have some warnings that we should try and get rid of:
/home/vvkulagin/anaconda3/envs/festim-env/lib/python3.11/site-packages/festim/generic_simulation.py:385: UserWarning: <class 'festim.exports.derived_quantities.adsorbed_hydrogen.AdsorbedHydrogen'> may not work as intended for cartesian meshes
warnings.warn(
/home/vvkulagin/anaconda3/envs/festim-env/lib/python3.11/site-packages/festim/generic_simulation.py:385: UserWarning: <class 'festim.exports.derived_quantities.total_surface.TotalSurface'> may not work as intended for cartesian meshes
warnings.warn(
- can we black format the notebook pls
- Maybe we can add a link to the Theory section if readers want more info?
RemDelaporteMathurin
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
@RemDelaporteMathurin, I don't know how detailed this demo should be. Moreover, let me know if statements/conclusion should be corrected to add clarity or whatever.