Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TotalSurface and AbsorbedHydrogen raise warnings in cartesian #829

Closed
RemDelaporteMathurin opened this issue Jul 30, 2024 · 0 comments · Fixed by #832
Closed

TotalSurface and AbsorbedHydrogen raise warnings in cartesian #829

RemDelaporteMathurin opened this issue Jul 30, 2024 · 0 comments · Fixed by #832
Labels
bug Something isn't working
Milestone

Comments

@RemDelaporteMathurin
Copy link
Collaborator

We noticed in festim-dev/FESTIM-workshop#67 that the derived quantities TotalSurface and AbsorbedHydrogen raised a warning even when used in cartesian meshes.

AbsorbedHydrogen should work with any system of coordinates.
TotalSurface shouldn't raise a warning in cartesian.

We should add them to:

# raise warning if the derived quantities don't match the type of mesh
# eg. SurfaceFlux is used with cylindrical mesh
all_types_quantities = [
festim.MaximumSurface,
festim.MinimumSurface,
festim.MaximumVolume,
festim.MinimumVolume,
festim.PointValue,
] # these quantities can be used with any mesh
allowed_quantities = {
"cartesian": [
festim.SurfaceFlux,
festim.AverageSurface,
festim.AverageVolume,
festim.TotalVolume,
]
+ all_types_quantities,
"cylindrical": [festim.SurfaceFluxCylindrical] + all_types_quantities,
"spherical": [festim.SurfaceFluxSpherical] + all_types_quantities,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant