Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(skype) ensure download with checksum before proceeding to uninstall older version #102

Closed
ferventcoder opened this issue Dec 11, 2015 · 3 comments
Labels

Comments

@ferventcoder
Copy link
Owner

See https://chocolatey.org/packages/skype#comment-2404221279

@cpmcgrath
Copy link

This seems like a case that chocolatey could handle better with the helper functions.

The simplest implementation to me would split Install-ChocolateyPackage into two functions, and then have Install-ChocolateyPackage just call them sequentially.

Then in cases like skype where you need to do an uninstall you could write something like...

$result = PrepareInstall-ChocolateyPackage $packageName $fileType $silentArgs $url
# do uninstall or whatever 
FinishInstall-ChocolateyPackage $result

@ferventcoder
Copy link
Owner Author

Actually there is already a split - Install-ChocolateyPackage is just Get-ChocolateyWebFile and Install-ChocolateyInstallPackage.

cpmcgrath added a commit to cpmcgrath/chocolatey-packages that referenced this issue Apr 15, 2016
@ferventcoder ferventcoder changed the title Skype - ensure download with checksum before proceeding to uninstall older version (skype) ensure download with checksum before proceeding to uninstall older version Nov 28, 2016
@gep13
Copy link
Collaborator

gep13 commented Jun 5, 2018

This package is now being maintained here:

https://github.com/chocolatey/chocolatey-coreteampackages

So going to close this out.

@gep13 gep13 closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants