(skype) migrated from ferventcoder/chocolatey-packages #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm aware that the install scripts are not compliant with the coding style of this repo, but I wanted to fix the package as quickly as possible and postpone code cleanup to a later time. |
|
Installer is indeed very poor. |
I've never been bothered by that myself, but I understand some users might be annoyed by that. Anyway, the package has been behaving like that for years, so I consider changing this to be out of scope of the migration process. |
The uninstall script has at least two bugs: 1) its registry uninstall key name filter is too broad and will pick up other technically unrelated applications, such as "Skype for Business" or "Skype Online PowerShell", 2) the script starts the uninstaller but does not wait for it to end, making the Chocolatey auto uninstaller fail with "another installation is in progress". The auto uninstaller of modern Chocolatey is perfectly capable of uninstalling Skype on its own, so let's avoid both problems by removing the uninstall script.
majkinetor
added
Requires chocolatey-community User
|
@majkinetor chocolatey user has been added |
AdmiringWorm
removed
the
Requires chocolatey-community User
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skype package migrated from https://github.com/ferventcoder/chocolatey-packages/tree/master/automatic/skype and converted to AU.
Motivation and Context
The package has been outdated and broken for a while now. A few days ago Microsoft restored the ability to install the classic Skype by publishing updated installers (7.41). This is a good opportunity to bring this package back to life, once more enabling users to install the most feature-rich Skype version.
How Has this Been Tested?
Tested two scenarios, both on Windows 10 1709:
Types of changes
Checklist:
Original Location
Migration of packages from ferventcoder's repository #900