Allow only common trigger options in multi-trigger apps #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
restrict-multi-trigger-flags
branch
from
07b81d6
to
296613e
Compare
rylev
approved these changes
Jan 30, 2024
| } | ||
| } | ||
|
|
||
| const COMMON_FLAGS: &[&str] = &[ |
There was a problem hiding this comment.
Can we comment that these flags are common to all well-known trigger types.
Comment on lines
+452
to
+453
| for i in 0..(args.len()) { | ||
| let Some(value) = args[i].to_str() else { |
There was a problem hiding this comment.
Suggested change
| for i in 0..(args.len()) { | |
| let Some(value) = args[i].to_str() else { | |
| for (i, arg) in args.iter().enumerate() { | |
| let Some(value) = arg.to_str() else { |
| }; | ||
| if value.starts_with('-') { | ||
| // Flag candidate. Is it allowed? | ||
| if !is_common_flag(value) { |
There was a problem hiding this comment.
Nit: I would personally inline this function.
|
@rylev Thanks for the review - all good points. Unfortunately, as we want to land this for 2.2, I'm going to have to punt them to a tidy-up PR - sorry. Also, as I'm already looking at Option 3 (and have it working on the happy path), which would enable trigger-specific flags, tidyings to this may become moot, but we'll see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2255 to address #2251