-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot pass trigger specific flags on up in multi trigger app #2251
Comments
As a user, I would expect passing the |
The least worst short-term solution may be simply to have triggers ignore unknown flags, although this does run us into the problem that Longer term we could consider some way for |
Semi-related: at some point, we may have a disambiguation issue, e.g. websocket |
We have a parallel problem with validating trigger config. Maybe the trigger plugin "interface" should include a mechanism for trigger executor binaries to describe their own config schema and arguments. |
I have an app that uses both a redis and a HTTP component. I was trying to set the HTTP listener to run on
3001
instead of3000
by passing in.which results in an error as the redis trigger does not recognize the flag.
Flags that are common like
--log-dir
continue to work.I am not exactly sure what the solution would be to this. One potential idea I can think of is that when multiple triggers are present spin can optionally parse arguments something along the lines of
--http-trigger="--listen localhost:3001"
and only pass the argument to the HTTP trigger. and anything not in those specific arguments gets passed to both?The text was updated successfully, but these errors were encountered: