Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Elixir 1.16 in CI #196

Merged
merged 3 commits into from
May 14, 2024
Merged

Add support for Elixir 1.16 in CI #196

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ec6b78
Add support for Elixir 1.16 in CI
s3cur3 May 8, 2024
890057d
Actually run the tests on every version
s3cur3 May 8, 2024
31c2758
Explictly specify versions per Jason
s3cur3 May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/elixir-build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,22 @@ jobs:
PGPASSWORD: postgres
strategy:
matrix:
elixir: ["1.11.4", "1.12.3", "1.13.4", "1.14.4", "1.15.5"]
otp: ["22.3", "23.3.4", "24.3.4", "25.3.2", "26.0.2"]
elixir: ["1.11.4", "1.12.3", "1.13.4", "1.14.4", "1.15.5", "1.16.2"]
otp: ["22.3", "23.3.4", "24.3.4", "25.3.2", "26.1.2"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of all the exclusions below it might be helpful to move to a list of versions that we check

matrix:
  include:
    - elixir-version: '1.12.1'
      otp-version: '24.0'
    - elixir-version: '1.11.4'
      otp-version: '23.3'
    - elixir-version: '1.10.4'
      otp-version: '22.3'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to explicitly specifying versions in 31c2758 👍

exclude:
# Elixir 1.11 doesn't support the latest OTP
- elixir: "1.11.4"
otp: "25.3.2"
- elixir: "1.11.4"
otp: "26.0.2"
otp: "26.1.2"
# Elixir 1.12 doesn't support the latest OTP
- elixir: "1.12.3"
otp: "25.3.2"
- elixir: "1.12.3"
otp: "26.0.2"
otp: "26.1.2"
# Elixir 1.13 doesn't support the latest OTP
- elixir: "1.13.4"
otp: "26.0.2"
otp: "26.1.2"
# Elixir 1.14 requires at least OTP 23
- elixir: "1.14.4"
otp: "22.3"
Expand All @@ -41,6 +41,11 @@ jobs:
otp: "22.3"
- elixir: "1.15.5"
otp: "23.3.4"
# Elixir 1.16 requires at least OTP 24
- elixir: "1.16.2"
otp: "22.3"
- elixir: "1.16.2"
otp: "23.3.4"

services:
db:
Expand Down Expand Up @@ -75,5 +80,4 @@ jobs:
run: mix test --warnings-as-errors

- name: Run tests
if: ${{ matrix.elixir == '1.11.4' }}
run: mix test
4 changes: 2 additions & 2 deletions .github/workflows/elixir-quality-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
# test stuff that isn't really relevant.
# The other checks don't really care what environment they run in.
MIX_ENV: dev
elixir: "1.15.4"
otp: "26.0.2"
elixir: "1.16.2"
otp: "26.1.2"

steps:
- name: Checkout repository
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/elixir-retired-packages-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
runs-on: ubuntu-latest
env:
MIX_ENV: dev
elixir: "1.15.4"
otp: "26.0.2"
elixir: "1.16.2"
otp: "26.1.2"

steps:
- name: Checkout repository
Expand Down
Loading