Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Elixir 1.16 in CI #196

Merged
merged 3 commits into from
May 14, 2024
Merged

Add support for Elixir 1.16 in CI #196

merged 3 commits into from
May 14, 2024

Conversation

s3cur3
Copy link
Contributor

@s3cur3 s3cur3 commented May 8, 2024

I figured it'd be good to have 1.16 tested in CI the same way we do other versions.

Copy link
Contributor

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is passing and testing the new version

Comment on lines 20 to 21
elixir: ["1.11.4", "1.12.3", "1.13.4", "1.14.4", "1.15.5", "1.16.2"]
otp: ["22.3", "23.3.4", "24.3.4", "25.3.2", "26.1.2"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of all the exclusions below it might be helpful to move to a list of versions that we check

matrix:
  include:
    - elixir-version: '1.12.1'
      otp-version: '24.0'
    - elixir-version: '1.11.4'
      otp-version: '23.3'
    - elixir-version: '1.10.4'
      otp-version: '22.3'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to explicitly specifying versions in 31c2758 👍

@s3cur3 s3cur3 merged commit 5484c6d into master May 14, 2024
22 checks passed
@s3cur3 s3cur3 deleted the ty/elixir-1-16 branch May 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants