Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored the frontend part of the project #82

Merged
merged 1 commit into from
Mar 8, 2020
Merged

Refactored the frontend part of the project #82

merged 1 commit into from
Mar 8, 2020

Conversation

hans-lizihan
Copy link
Contributor

@hans-lizihan hans-lizihan commented Mar 7, 2020 •
edited
Loading

Just extract different component within Queue.tsx to it's own component.

I wish I could introduce react-router for viewing each queue and support pagination as well in the future

and

  • Delete static folder
  • Fixed build script for index.ejs

@hans-lizihan
Refactored the frontend part of the project
f9235d9 
Delete static folder
Fixed build script for index.ejs
vcapretz
vcapretz approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@vcapretz vcapretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thank you for the PR and for the fixes, I'll make it available in the next alpha release 😄

@vcapretz vcapretz merged commit c80dfe1 into felixmosh:master Mar 8, 2020
@vcapretz vcapretz mentioned this pull request Mar 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcapretz vcapretz vcapretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hans-lizihan @vcapretz