Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index.ejs not copied to dist folder #81

Closed
wants to merge 2 commits into from

Conversation

hieptuanle
Copy link

Fix issue #65

This PR just copy index.ejs file from src/ui to dist/ui. I add a new library cpx because I don't want to write a bash script and mess with Windows users.

@@ -66,6 +67,7 @@
"babel-preset-react-app": "^7.0.2",
"bull": "^3.12.1",
"bullmq": "^1.6.6",
"cpx": "^1.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any documentation that this indeed supports windows, have you tried it yourself?

Also the docs state

Copy file globs, watching for changes.

This module provides a CLI tool like cp, but with watching.

We're not really interested in watching for changes - could this have unforeseen side-effects? Would perhaps be better with a more plain file-copy lib.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually i did not test it on Windows. I will test it next time 👍

@vcapretz
Copy link
Contributor

vcapretz commented Mar 8, 2020

hey @hieptuanle, thank you very much for taking the time to contribute to the project, really appreciate it 😄

I just merged #82 and the same issue was solve there, so I'll close your PR

if you want to contribute more I would be very glad to review more PRs 👍

@vcapretz vcapretz closed this Mar 8, 2020
@hieptuanle
Copy link
Author

@vcapretz No problems! Thanks for your useful project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants