-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update composer.json php codesniffer #471
Conversation
it has been released in 3.0.X as stable
Build's broken. There was a problem with the CodeSniffer 3 autoloader. If you can fix that, happy to upgrade |
hmmm it seems to be because of this change in php code sniffer squizlabs/PHP_CodeSniffer@566a0cd#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780L27 :( |
to include manually the autoload from php_codesniffer see squizlabs/PHP_CodeSniffer@566a0cd#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780L27
You can create a tests/bootstrap.php file and include the autoload there <?php
require __DIR__ . '/../vendor/autoload.php';
require __DIR__ . '/../vendor/squizlabs/php_codesniffer/autoload.php'; |
That would fix it for tests, but does it fix it at runtime? |
Can't really tell right now, I'm trying to debug vscode-php-intellisense, after the symlink and press
I cloned the master branch |
That's not a very helpful error stack. Do you have the right version of Node? Did you run |
I didn't see an error that
I'll keep trying... EDIT: It was a corrupted install, nuked node_modules folders, reinstall and buid ok. It works |
At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases, overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway. BREAKING CHANGE: removes formatting support closes felixfbecker#501 closes felixfbecker#474 closes felixfbecker#473 closes felixfbecker#468 closes felixfbecker#450 closes felixfbecker#445 closes felixfbecker#443 closes felixfbecker#423 closes felixfbecker#343 closes felixfbecker#296 closes felixfbecker#293 closes felixfbecker#499 closes felixfbecker#471
it has been released in 3.0.X as stable