Error when formatting files without namespace #293
Labels
Comments
felixfbecker
changed the title
|
Can you post the file please? |
|
The name of the file is: 2017_02_09_173745_add_registra_iva_to_establecimientos.php <?php
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;
class AddRegistraIvaToEstablecimientos extends Migration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
Schema::table('establecimientos', function (Blueprint $table) {
$table->boolean('registra_iva')->default(1)->after('tiene_pedido_mesa');
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
Schema::table('establecimientos', function (Blueprint $table) {
$table->dropColumn('registra_iva');
});
}
} |
|
I got this error today when trying to format a php file containing only: <?php
class SomeClass
{
}edit: |
felixfbecker
added a commit
that referenced
this issue
Oct 28, 2017
felixfbecker
added a commit
that referenced
this issue
Oct 28, 2017
felixfbecker
added a commit
that referenced
this issue
Oct 28, 2017
felixfbecker
added a commit
that referenced
this issue
Oct 28, 2017
felixfbecker
added a commit
that referenced
this issue
Oct 28, 2017
felixfbecker
added a commit
that referenced
this issue
Nov 5, 2017
At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases, overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway. BREAKING CHANGE: removes formatting support closes #501 closes #474 closes #473 closes #468 closes #450 closes #445 closes #443 closes #423 closes #343 closes #296 closes #293 closes #499 closes #471
Open
cgxxv
pushed a commit
to cgxxv/php-language-server
that referenced
this issue
Mar 25, 2022
At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases, overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway. BREAKING CHANGE: removes formatting support closes felixfbecker#501 closes felixfbecker#474 closes felixfbecker#473 closes felixfbecker#468 closes felixfbecker#450 closes felixfbecker#445 closes felixfbecker#443 closes felixfbecker#423 closes felixfbecker#343 closes felixfbecker#296 closes felixfbecker#293 closes felixfbecker#499 closes felixfbecker#471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From @andreshg112 on February 9, 2017 22:42
I'm getting this error in class files where there's no a defined namespace:
Copied from original issue: felixfbecker/vscode-php-intellisense#72
The text was updated successfully, but these errors were encountered: