Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to format file #468

Closed
karimsaieh opened this issue Aug 23, 2017 · 10 comments · Fixed by #504
Closed

Unable to format file #468

karimsaieh opened this issue Aug 23, 2017 · 10 comments · Fixed by #504
Labels
bug formatting

Comments

@karimsaieh
Copy link 

[Error - 13:49:16] Request textDocument/formatting failed.
Message: Exception: Unable to format file in C:\Users\karim\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\felixfbecker\language-server\src\Formatter.php:52
Stack trace:
#0 C:\Users\karim\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\felixfbecker\language-server\src\PhpDocument.php(179): LanguageServer\Formatter::format('<?php\n\nnamespac...', 'file:///c:/wamp...')
#1 C:\Users\karim\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\felixfbecker\language-server\src\Server\TextDocument.php(172): LanguageServer\PhpDocument->getFormattedText()
#2 C:\Users\karim\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Promise.php(242): LanguageServer\Server\TextDocument->LanguageServer\Server\{closure}(Object(LanguageServer\PhpDocument))
#3 C:\Users\karim\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Loop\Loop.php(261): Sabre\Event\Promise->Sabre\Event\{closure}()
#4 C:\Users\karim\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Loop\Loop.php(215): Sabre\Event\Loop\Loop->runNextTicks()
#5 C:\Users\karim\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Loop\Loop.php(194): Sabre\Event\Loop\Loop->tick(true)
#6 C:\Users\karim\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Loop\functions.php(122): Sabre\Event\Loop\Loop->run()
#7 C:\Users\karim\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\felixfbecker\language-server\bin\php-language-server.php(50): Sabre\Event\Loop\run()
#8 {main}
  Code: -32603

I noticed this error happens when i try to format a file already formatted
@thc1967
Copy link

thc1967 commented Aug 24, 2017 •
edited
Loading

I get a similar error when I try to format a PHPUnit test case class.

  Message: Exception: Unable to format file in C:\Users\username\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\felixfbecker\language-server\src\Formatter.php:52
Stack trace:
#0 C:\Users\username\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\felixfbecker\language-server\src\PhpDocument.php(179): LanguageServer\Formatter::format('<?php\n\nnamespac...', 'file:///d:/thc/...')
#1 C:\Users\username\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\felixfbecker\language-server\src\Server\TextDocument.php(172): LanguageServer\PhpDocument->getFormattedText()
#2 C:\Users\username\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Promise.php(242): LanguageServer\Server\TextDocument->LanguageServer\Server\{closure}(Object(LanguageServer\PhpDocument))
#3 C:\Users\username\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Loop\Loop.php(261): Sabre\Event\Promise->Sabre\Event\{closure}()
#4 C:\Users\username\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Loop\Loop.php(215): Sabre\Event\Loop\Loop->runNextTicks()
#5 C:\Users\username\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Loop\Loop.php(194): Sabre\Event\Loop\Loop->tick(true)
#6 C:\Users\username\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\sabre\event\lib\Loop\functions.php(122): Sabre\Event\Loop\Loop->run()
#7 C:\Users\username\.vscode\extensions\felixfbecker.php-intellisense-1.5.1\vendor\felixfbecker\language-server\bin\php-language-server.php(50): Sabre\Event\Loop\run()
#8 {main}
  Code: -32603

@ivanrvpereira
Copy link

same here

@felixfbecker
Copy link
Owner

Formatting is done through PHP CodeSniffer. I'm waiting on pretty printing support from @roblourens to switch over

@felixfbecker felixfbecker mentioned this issue Sep 11, 2017
Closed
@vmohir
Copy link

vmohir commented Oct 7, 2017

same here

@tmattos
Copy link

tmattos commented Oct 9, 2017

same problem here

@stormpat
Copy link

Same

@TortleWortle
Copy link

Same here :/

@pabrrs
Copy link

pabrrs commented Oct 15, 2017

same here

1 similar comment
@kuerme
Copy link

kuerme commented Oct 18, 2017

same here

@cobaltutby
Copy link

same:(

felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
1b0ef42 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
@felixfbecker felixfbecker mentioned this issue Oct 28, 2017
Merged
felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
02ebde3 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
648dd25 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
326c9a2 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this issue Oct 28, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer
4b81c33 
BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
felixfbecker added a commit that referenced this issue Nov 5, 2017
@felixfbecker
fix(formatting): drop PHP CodeSniffer (#504)
f00fd1b 
At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases, overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway.

BREAKING CHANGE: removes formatting support

closes #501
closes #474
closes #473
closes #468
closes #450
closes #445
closes #443
closes #423
closes #343
closes #296
closes #293
closes #499
closes #471
@dependencies dependencies bot mentioned this issue Nov 5, 2017
Closed
cgxxv pushed a commit to cgxxv/php-language-server that referenced this issue Mar 25, 2022
@felixfbecker
fix(formatting): drop PHP CodeSniffer (felixfbecker#504)
0845a16 
At this point there are countless issues about the formatting done by CodeSniffer. It plain out doesn't work in many cases, overrides format options that are contributed by other extensions in VS Code and does not reuse any of our AST parsing. For that reason, I am starting to think there is no reason to keep it in here until we have proper pretty-printing support from https://github.com/Microsoft/tolerant-php-parser that actually reuses our ASTs and can work while editing. For people who want to use CodeSniffer to format their code, there could be a standalone CodeSniffer language server (like there is a TSLint language server and ESLint language server). As said, we don't reuse our state anyway.

BREAKING CHANGE: removes formatting support

closes felixfbecker#501
closes felixfbecker#474
closes felixfbecker#473
closes felixfbecker#468
closes felixfbecker#450
closes felixfbecker#445
closes felixfbecker#443
closes felixfbecker#423
closes felixfbecker#343
closes felixfbecker#296
closes felixfbecker#293
closes felixfbecker#499
closes felixfbecker#471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(formatting): drop PHP CodeSniffer felixfbecker/php-language-server