Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and fix for PhotometryData initialization #470

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Oct 12, 2024

Fixes #469 by using self to get at the data instead of input_data after BaseEnhancedTable has fixed up column names.

@mwcraig mwcraig added this to the 2.0.0-beta milestone Oct 12, 2024
@mwcraig mwcraig requested a review from JuanCab October 12, 2024 16:53
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.05%. Comparing base (5260c1c) to head (5eb4d68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files          31       31           
  Lines        4011     4011           
=======================================
  Hits         3211     3211           
  Misses        800      800           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JuanCab
JuanCab previously approved these changes Oct 13, 2024
Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this may have been a design error of my origin, sorry! Glad you fixed it.

stellarphot/core.py Outdated Show resolved Hide resolved
Co-authored-by: Juan Cabanela <[email protected]>
@mwcraig mwcraig merged commit eb6a7c1 into feder-observatory:main Oct 13, 2024
5 of 7 checks passed
@mwcraig mwcraig deleted the fix-photometry-data-issue branch October 13, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PhotometryData does not use column name mapping
2 participants