Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhotometryData does not use column name mapping #469

Closed
mwcraig opened this issue Oct 12, 2024 · 0 comments · Fixed by #470
Closed

PhotometryData does not use column name mapping #469

mwcraig opened this issue Oct 12, 2024 · 0 comments · Fixed by #470
Assignees
@mwcraig
Labels
bug Something isn't working New base/data classes Develop a base class for the new `astropy.table.Table`+headers class
Milestone
2.0.0-beta

Comments

@mwcraig
Copy link
Contributor

mwcraig commented Oct 12, 2024

It turns out that PhotometryData does not used the remapped column names in its __init__. I'll open a PR with a test that reproduces the issue and fixes it in a moment.
@mwcraig mwcraig added bug Something isn't working New base/data classes Develop a base class for the new `astropy.table.Table`+headers class labels Oct 12, 2024
@mwcraig mwcraig added this to the 2.0.0-beta milestone Oct 12, 2024
@mwcraig mwcraig self-assigned this Oct 12, 2024
@mwcraig mwcraig mentioned this issue Oct 12, 2024
Merged
@mwcraig mwcraig changed the title PhotometryData does use column name mapping PhotometryData does not use column name mapping Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwcraig mwcraig

Labels
bug Something isn't working New base/data classes Develop a base class for the new `astropy.table.Table`+headers class
Projects
None yet
Milestone
2.0.0-beta
Development

Successfully merging a pull request may close this issue.

Add test and fix for PhotometryData initialization mwcraig/stellarphot
1 participant
@mwcraig