Better handle disabling widgets when displaying #308
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 73.71% 73.76% +0.04%
==========================================
Files 27 27
Lines 3390 3396 +6
==========================================
+ Hits 2499 2505 +6
Misses 891 891 ☔ View full report in Codecov by Sentry. |
mwcraig
force-pushed
the
fix-autoui-disabled-state
branch
from
cf1804c to
66e376d
Compare
| top.disabled = value | ||
| elif isinstance(top, ItemBox): |
There was a problem hiding this comment.
I'll admit I am trusting your tests because I don't know pyautoui well.
| # There is no great way to get to the ItemBox widget that contains and controls | ||
| # the add/remove buttons, so we keep going down through widget children until we | ||
| # get to an ItemBox and then check that the buttons are disabled. | ||
| # Recursion is the easiest way to do that, so recurse we will.. |
There was a problem hiding this comment.
Wow, an actual use for recursion that isn't factorials or the Fibonacci sequence or binary search...
|
Doing some more testing here and noticed some odd interaction. This results in you not being able to enter a name for the passband map and therefore unable to save it. Is this something we need to address? Beyond this I did not find anymore bugs... yet.
|
Good catch -- I think that was fixed by #307 but will check once all of these are merged |
This addresses the first two items in #303, so when merged it fixes #303.
The original method of disabling and re-enabling the fields of a model when displaying vs editing or making a new item was a little too aggressive, and ended up enabling something elements that should not have been enabled.
This fixes that by only disabling
AutoObjects and also hiding the add/remove buttons that appear in thePassbandMapobject.