Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Edit" button issues #307

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Apr 29, 2024

This PR addresses the edit button issues mentioned in #303. The other issues will be addressed in a separate PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.72%. Comparing base (70f74be) to head (1b74bf2).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   73.70%   73.72%   +0.02%     
==========================================
  Files          27       27              
  Lines        3388     3391       +3     
==========================================
+ Hits         2497     2500       +3     
  Misses        891      891              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tanner728
Copy link
Contributor

I will be at tutoring for the next few hours but will have a chance to take a look later tonight.

@Tanner728
Copy link
Contributor

Hello, after some testing I found a weird bug.
The bug is the edit this observatory button disappears.
The steps that I did to cause this were as follows.

  1. Create a valid observatory.
  2. Switch the menu to Make a new Observatory.
  3. Switch back to the observatory you had previously created.

Now the Edit this observatory button should not appear and you are unable to edit the observatory. To fix this you can just recreate the menu but the issue appears every time you follow those steps.

image

@mwcraig
Copy link
Contributor Author

mwcraig commented Apr 30, 2024

Thanks @Tanner728 -- I think I have fixed that now.

Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests looks reasonable.

Copy link
Contributor

@Tanner728 Tanner728 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not been able to find anymore bugs with the UI at this point.

@mwcraig mwcraig merged commit b617348 into feder-observatory:main May 1, 2024
9 checks passed
@mwcraig mwcraig deleted the fix-ui-issues branch May 1, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants