Fixing non-NaNable ccd images #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcraig
requested changes
Aug 17, 2023
mwcraig
requested changes
Aug 17, 2023
| @@ -255,8 +255,8 @@ def single_image_photometry(ccd_image, sourcelist, camera, observatory_location, | |||
| "SKIPPING THIS IMAGE!") | |||
| return None, None | |||
|
|
|||
| # Set high pixels to NaN | |||
| ccd_image.data[ccd_image.data > max_adu] = np.nan | |||
| # Set high pixels to NaN (make sure ccd_image.data is a float array first) | |||
There was a problem hiding this comment.
I think you still need a line here making the data float, it just doesn't need a type check:
Suggested change
| # Set high pixels to NaN (make sure ccd_image.data is a float array first) | |
| # Set high pixels to NaN (make sure ccd_image.data is a float array first) | |
| ccd_image.data = ccd_image.data.astype(float) |
There was a problem hiding this comment.
Didn't I cast it to float during the NaN replacement? (On iPhone, can't see code)
There was a problem hiding this comment.
You cast it as float for the comparison (inside the brackets) but the data itself is still int I think
There was a problem hiding this comment.
I think I fixed it now.
|
OK, it is now fixed. Sigh. I would have sworn I had been clever. Can you PLEASE test this with the integer image, just in case?
|
|
I just pushed a test which I verified fails without your fix 🎉 but unfortunately found out about #161 along the way 😭 . |
mwcraig
approved these changes
Aug 17, 2023
… flagging with NaN.
JuanCab
force-pushed
the
PreSemesterTweaks
branch
from
9e6e437 to
56c7e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a fix for the ccddata not being NaN-able by converting it to float if needed. Can you check that your image will now process.
I also updated the CHANGES.rst file to cover recent changes.
Fixes #157