Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute_fwhm fails if there are NaN values in the input #161

Closed
mwcraig opened this issue Aug 17, 2023 · 2 comments · Fixed by #164
Closed

compute_fwhm fails if there are NaN values in the input #161

mwcraig opened this issue Aug 17, 2023 · 2 comments · Fixed by #164
Labels
bug Something isn't working refactor Summer 2023 project to rewrite stellarphot
Milestone
2.0.0 -- alpha

Comments

@mwcraig
Copy link
Contributor

mwcraig commented Aug 17, 2023

It turns out that compute_fwhm fails if there are NaNs in the input data. Though there is an option to filter out infinite values (i.e. np.inf) but no way in astropy modeling to filter out np.nan though the documentation explains how to do that in a note.
@mwcraig mwcraig added bug Something isn't working refactor Summer 2023 project to rewrite stellarphot labels Aug 17, 2023
@mwcraig mwcraig mentioned this issue Aug 17, 2023
Merged
@JuanCab
Copy link
Contributor

JuanCab commented Aug 17, 2023

Is there a possibility you reverted the fix I applied in PR #145 to fix Issue #142 or is this a new error?

@mwcraig
Copy link
Contributor Author

mwcraig commented Sep 3, 2023

Have confirmed it is a real issue, think I found the cause. PR coming soon...

@mwcraig mwcraig mentioned this issue Sep 3, 2023
Merged
@mwcraig mwcraig moved this from 🆕 New to 👀 In review in stellarphot refactoring Sep 4, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in stellarphot refactoring Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working refactor Summer 2023 project to rewrite stellarphot
Projects
stellarphot refactoring
Status: ✅ Done
Milestone
2.0.0 -- alpha
Development

Successfully merging a pull request may close this issue.

Fix calculation of FWHM when the input data has non-finite values mwcraig/stellarphot
2 participants
@mwcraig @JuanCab