Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_fwhm() throws exception on images with NaN #142

Closed
JuanCab opened this issue Jul 30, 2023 · 2 comments
Closed

compute_fwhm() throws exception on images with NaN #142

JuanCab opened this issue Jul 30, 2023 · 2 comments
Labels
refactor Summer 2023 project to rewrite stellarphot

Comments

@JuanCab
Copy link
Contributor

JuanCab commented Jul 30, 2023

In essence, it would be nice if the photometry code in single_image_photometry() could use NaN to flag saturated pixels, as the photometry routines all know to ignore NaN and process the images correctly. The old photutils_stellar_photometry() function used this approach. Unfortunately, when calling compute_fwhm() an exception is thrown because NaN are not allowed in input data by the LevMarLSQFitter() function.

@mwcraig
Copy link
Contributor

mwcraig commented Jul 30, 2023

It would be worth checking to see whether there is a fwhm calculator in photutils these days, but otherwise I'm fine with using NaN.

photutils understands masks too, so that is another option if photutils has fwhm again.

@mwcraig mwcraig added the refactor Summer 2023 project to rewrite stellarphot label Jul 30, 2023
@JuanCab
Copy link
Contributor Author

JuanCab commented Aug 1, 2023

Fixed in PR #145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Summer 2023 project to rewrite stellarphot
Projects
Status: Done
Development

No branches or pull requests

2 participants