Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/1748 remove is-nightly-run flag from circleci config #2363

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feature/1748 remove is-nightly-run flag from circleci config #2363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,20 +205,14 @@ jobs:
# Invoke jobs via workflows
# See: https://circleci.com/docs/2.0/configuration-reference/#workflows
parameters:
is-nightly-run:
type: boolean
default: false

is-triggered-e2e-test:
type: boolean
default: false

workflows:
primary:
when:
and:
- not: << pipeline.parameters.is-nightly-run >>
- not: << pipeline.parameters.is-triggered-e2e-test >>
not: << pipeline.parameters.is-triggered-e2e-test >>
jobs:
- lint
- test
Expand All @@ -237,11 +231,6 @@ workflows:
branches:
only: /develop|release\/sprint-[\.\d]+|main/

nightly-run:
when: << pipeline.parameters.is-nightly-run >>
jobs:
- e2e-test

# This job is run when an e2e test is triggered with the
# is-triggered-e2e-test parameter via the fecfile-web-api
# circleci config file. It is used to run the e2e tests
Expand Down
2 changes: 1 addition & 1 deletion front-end/cypress/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ To run in headless mode, run the command: ng e2e --headless

## E2E tests in CircleCI

A new job was added to the CircleCI fecfile-web-app configuration to run the E2E test suite nightly. This job uses CircleCI's [Docker executor](https://circleci.com/docs/building-docker-images/#run-docker-commands-using-the-docker-executor) to spin up an instance of the fecfile-web-api using Docker Compose in an isolated remote docker instance.
A new job was added to the CircleCI fecfile-web-app configuration to run the E2E test suite when triggered. This job uses CircleCI's [Docker executor](https://circleci.com/docs/building-docker-images/#run-docker-commands-using-the-docker-executor) to spin up an instance of the fecfile-web-api using Docker Compose in an isolated remote docker instance.

For security reasons, CircleCI's remote docker [does not allow mounting volumes](https://circleci.com/docs/building-docker-images/#mounting-folders), and thus our compose `volumes` commands fail. To get around this, we had to create two new E2E Dockerfiles for the API/Worker to add these filesystem resources to the images directly.

Expand Down