feature/1748 remove is-nightly-run flag from circleci config #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheitzer
requested review from
toddlees,
Elaine-Krauss-TCG and
sasha-dresden
sasha-dresden
approved these changes
Nov 13, 2024
|
The E2E tests got run, and we wouldn't normally see them run for a regular PR. If this is intended and not a new config issue, then disregard! |
Nice catch @Elaine-Krauss-TCG. Actually I kicked them off manually to ensure the negative test case worked as well :). They failed as expected since there was no corresponding api branch. Thank you for checking! |
toddlees
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket link: https://fecgov.atlassian.net/browse/FECFILE-1748
Related PRs: