Add www redirects for form 1 and former_members paths

[dorothyyeager]

• Redirects www.fec.gov/pdf/fecfrm1 to its new URL at https://www.fec.gov/resources/cms-content/documents/policy-guidance/fecfrm1.pdf
• Redirects /members/former_members/... to /resources/about-fec/commissioners/....
  • Resolves issue #5956
• Temporarily disable incorrect redirect for non-existent policy-guidance/documents
• Fixes incorrect redirect for national-party-committee-accounts:
  ^/updates/fec-issues-interim-reporting-guidance-for-national-party-committee-accounts/ /updates/guidance-search/fec-issues-interim-reporting-guidance-for-national-party-committee-accounts/

How to test:

• This is deployed to dev
• You can test fcfrm1 redirect here: https://dev.fec.gov/pdf/forms/fecfrm1.pdf
• You can test the former_members redirect by going to http://dev.fec.gov/members/former_members/thomas/thomasarticle08.pdf
  Then change dev to www in the resulting URL to see the PDF. (since these docs are not on dev S3)
• Test that https://dev.fec.gov/updates/fec-issues-interim-reporting-guidance-for-national-party-committee-accounts/ goes to the correct page (currently goes to Van Hollen page on prod)

[johnnyporkchops]

@dorothyyeager , Do we want to correct that broader, incorrect redirect for PDF forms too?
rewrite ^/pdf/forms/(.*) https://www.fec.gov/resources/cms-content/policy-guidance/documents/$1 redirect;

[dorothyyeager]

Hi John. Not yet. There are some forms that only redirect via that redirect. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: John Carroll ***@***.***> Sent: Thursday, October 19, 2023 10:10:41 PM To: fecgov/fec-proxy ***@***.***> Cc: Dorothy Yeager ***@***.***>; Mention ***@***.***> Subject: Re: [fecgov/fec-proxy] Add www redirect for form 1 path (PR #379) @dorothyyeager<https://github.com/dorothyyeager> , Do we want to correct that broader, incorrect redirect for PDF forms too? rewrite ^/pdf/forms/(.*) https://www.fec.gov/resources/cms-content/policy-guidance/documents/$1 redirect; — Reply to this email directly, view it on GitHub<#379 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AF2OE6IQIV2A3NI6HZPYPDTYAHMSDAVCNFSM6AAAAAA6HS6HSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRHE3DINZUGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[johnnyporkchops]

@dorothyyeager Why are we redirecting the original /updates/.. pages to their alias in /guidance-search? The pages are always identical so there is no reason to redirect unless you want the user to see a certain path in the URL and if that's the case, shoudn't we be redirecting the alias back to the original? In other words, if a user finds a page in the policy-guidance search results with a URL containing /updates/guidance-search/..., when they click on it, it brings them to the page in its original location among all the other /updates pages.

fec-proxy/redirects-www.conf

Line 475 in 43c02d1

# Redirects for /updates/

[dorothyyeager]

We don’t want two identical pages. We only want one of each. The plan is to delete the old ones once redirects are working. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: John Carroll ***@***.***> Sent: Wednesday, October 25, 2023 1:19:29 AM To: fecgov/fec-proxy ***@***.***> Cc: Dorothy Yeager ***@***.***>; Mention ***@***.***> Subject: Re: [fecgov/fec-proxy] Add www redirects for form 1 and former_members paths (PR #379) @dorothyyeager<https://github.com/dorothyyeager> Why are we redirecting the original /updates pages to their alias in /guidance-search? The pages are always identical so there is no reason to redirect unless you want the user to see a certain path in the URL and if that's the case, shoudn't we be redirecting the alias back to the original. In other words, if a user finds a page in the policy-guidance search results with a URL containing /updates/guidance-search/..., when they click on it, it brings them to the page in its original location among all the other /updates pages. https://github.com/fecgov/fec-proxy/blob/43c02d192e51c138151ca732cc137c37015a6de5/redirects-www.conf#L475 — Reply to this email directly, view it on GitHub<#379 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AF2OE6NACRJCXBJD76C5FFLYBCOODAVCNFSM6AAAAAA6HS6HSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZYGUZTCMZQHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[johnnyporkchops]

We don’t want two identical pages. We only want one of each. The plan is to delete the old ones once redirects are working.

@dorothy, We do not have two identical pages, we have one page with an alias in another location. To reiterate, the Wagtail aliased page automatically matches the original and the editor never has to access it or edit the alias. Another reason we chose this setup is that if the Policy guidance setup changes or we end up discontinuing that requirement, then we do not have to keep moving pages and putting in redirects (technical debt). I probably should have demoed the alias function in Wagtail rather than just explaining it. Perhaps I can do that as part of this discussion.

Also, If we were to delete the original page from /updates and move it to /guidance-search/, then it would no longer show up when someone filtered for it on the /updates page.

I am also looking at a way to sync the policy pdfs to the policy-guidance directory (not just copy them)... again so that content does not get moved all over the place and cause us linking and redirect headaches... all for the godforsaken policy-guidance requirement 😃