Adds redirect for the 2002 meeting minutes #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patphongs
reviewed
Oct 11, 2019
redirects-transition.conf
Outdated
| @@ -242,6 +242,7 @@ rewrite ^/info/tips/(.*) https://www.fec.gov/updates/?update_type=tips-for-treas | |||
| rewrite ^/pdf/nprm/(.*) https://www.fec.gov/resources/legal-resources/rulemakings/nprm/$1 redirect; | |||
| rewrite ^/agenda/([0-9]+)/documents/(.*) https://www.fec.gov/resources/updates/agendas/$1/$2 redirect; | |||
| rewrite ^/agenda/([0-9]+)/(.*).pdf https://www.fec.gov/resources/updates/agendas/$1/$2.pdf redirect; | |||
| rewrite ^/agenda/agendas2002/(.*).pdf https://www.fec.gov/resources/updates/agendas/$1 redirect; | |||
There was a problem hiding this comment.
@dorothyyeager Can you please make the same changes in this file as was commented here? #148 (review)
There was a problem hiding this comment.
Thanks @patphongs - I've made the changes to this file. Appreciate your help with this!
Corrects redirect for agenda/agendas2002/ and adds redirects for agenda/agendas2000, agenda/agendas2001, and /agendas2003
patphongs
reviewed
Oct 11, 2019
redirects-transition.conf
Outdated
Comment on lines
245
to
248
| rewrite ^/agenda/agendas2003/(.*).pdf https://www.fec.gov/resources/updates/agendas/2003/$1 redirect; | ||
| rewrite ^/agenda/agendas2002/(.*).pdf https://www.fec.gov/resources/updates/agendas/2002/$1 redirect; | ||
| rewrite ^/agenda/agendas2001/(.*).pdf https://www.fec.gov/resources/updates/agendas/2001/$1 redirect; | ||
| rewrite ^/agenda/agendas2000/(.*).pdf https://www.fec.gov/resources/updates/agendas/2000/$1 redirect; |
There was a problem hiding this comment.
Same changes need to be made as specified here: #148 (review)
There was a problem hiding this comment.
Done. Thank you again!
Added .pdf to agendas/agendasXXXX/ redirects. Thank you @patphongs
patphongs
approved these changes
Oct 11, 2019
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2002 meeting minutes were in a subdirectory with a different name path than other years, so are 404'ing.
Old path: /agenda/agendas2002/*.pdf
I've put in a broader redirect for that subdirectory.
If this works, it resolves #3266