Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

UX tweaks for MVP #651

Merged
merged 6 commits into from
Jan 13, 2022
Merged

UX tweaks for MVP #651

merged 6 commits into from
Jan 13, 2022

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Dec 31, 2021

Summary

Related PR:
A PR to regulations-site's master branch supports this PR:
fecgov/regulations-site#2

Required reviewers

@pkfec and possibly @JonellaCulmer if we can push it to Dev

Impacted areas of the application

modified: fec_eregs/static/regulations/css/scss/module/_custom.scss
modified: https://github.com/fecgov/regulations-site/blob/master/regulations/templates/regulations/generic_help.html

Screenshots

Mobile TOC Toggle to show obscured content:

eregs_mobile-toggle


Related PRs

A PR to regulations-site's master branch supports this PR:
fecgov/regulations-site#2

How to test

  • checkout branch and run python manage.py compile_frontend
  • Run Eregs locally as you normally would
  • See that TOC toggle button is now available
  • Test in Mobile view to ensure users can now hide TOC to access content below
  • Confirm that the only icons in the help sidebar are the open/close arrows for the TOC toggle
  • The new Search regulations link in help-sidebar wont work locally because in production, the relative URL is in the context of fec.gov, not localhost. But you can see that fec.gov/regulations goes to the right place.

Copy link
Contributor

@pkfec pkfec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnnyporkchops. Deployed a test branch onto dev space and tested the changes. TOC toggle is super helpful while browsing Regs on mobile and on a browser. Thanks for adding the toogle feature to eregs TOC menu.

Works as expected!

@johnnyporkchops johnnyporkchops changed the title UX tweaks for MVP [WIP] UX tweaks for MVP Jan 10, 2022
@johnnyporkchops johnnyporkchops changed the title [WIP] UX tweaks for MVP UX tweaks for MVP Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVP UX tweaks to Eregs frontend
2 participants