This repository has been archived by the owner on May 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restore TOC toggle so Mobile users can access obscured content (see GIF below)
Remove unused help icons in help-sidebar (this change is on master branch of regulations-site)
Add link to search box (Eregs home) in help menu
Resolves MVP UX tweaks to Eregs frontend #639
Also resolves:
e-regs right-sidebar still notes some of the removed features/buttons #533
On mobile, TOC remains open on top of content #476
eRegs display issue: TOC covers part of text on mobile devices #449
Related PR:
A PR to regulations-site's master branch supports this PR:
fecgov/regulations-site#2
Required reviewers
@pkfec and possibly @JonellaCulmer if we can push it to Dev
Impacted areas of the application
modified: fec_eregs/static/regulations/css/scss/module/_custom.scss
modified: https://github.com/fecgov/regulations-site/blob/master/regulations/templates/regulations/generic_help.html
Screenshots
Mobile TOC Toggle to show obscured content:
Related PRs
A PR to regulations-site's master branch supports this PR:
fecgov/regulations-site#2
How to test
python manage.py compile_frontend
open/close arrows
for the TOC toggleSearch regulations
link in help-sidebar wont work locally because in production, the relative URL is in the context of fec.gov, not localhost. But you can see that fec.gov/regulations goes to the right place.