404 instead of 500s for bad calls in eRegs

[LindsayYoung]

This came up in scanning. I think there should be a way add some resolve or 404 logic with django

[AmyKort]

@ccostino

[ccostino]

I caught up with @LindsayYoung and what we're after here is updating the URL resolution (routing) to go through the e-regs application itself instead of the proxy app/router right now. What this means is making sure the e-regs application has the routes setup to handle these URLs if it doesn't already, and possibly updating some view logic to make use of Django's get_object_or_404() method.

[ccostino]

These 500 errors may also be related to eregs/regulations-site#485 - I'm seeing a lot of these in the logs recently.

[ccostino]

This issue will need to be fixed in https://github.com/eregs/regulations-site, not here.

[ccostino]

Seeing as how this is something that has to be done in the core eregs platform, all we should have to do once this is addressed is update the dependency for regulations-site to the new version once it's available.

[ccostino]

Unfortunately there is no one staffed to eregs at the moment, but we can help ourselves here and coordinate with folks at 18F who are in the know about it! The issue to address this is here: eregs/regulations-site#485 - if someone is able to take a look at this, we could probably get a PR in place to fix the issue and have someone merge it into the underlying eregs regulations-site module. :-)

[ccostino]

Specifically, the fix here will be just to update the module once the fix is made in https://github.com/eregs/regulations-site - for details on the fix, please see the ticket associated with it: eregs/regulations-site#485

[lbeaufort]

Update: The PR to eregs (eregs/regulations-site#515) was merged. Once there's a new release, we need to update our requirements.txt (https://github.com/fecgov/fec-eregs/blob/develop/requirements.txt#L22) with the new regulation-site version here: https://github.com/eregs/regulations-site/blob/master/setup.py#L6

[lbeaufort]

Addressed by #405