This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Throw 404 for missing data #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Addresses issue eregs#485: Missing data leads to an explosion - Also addresses FEC issue: fecgov/fec-eregs#385 - Throw a 404 error when navigating to a regulation that doesn't exist - Previously, the `utils.regulation_meta` function was returning `{}`, so accessing the 'meta' data was resulting in a 500 error
- Accessing the site was causing an error - Previously, we needed to add 0.0.0.0 to `ALLOWED_HOSTS` manually.
cmc333333
approved these changes
May 14, 2018
cmc333333
pushed a commit
to cmc333333/regulations-site
that referenced
this pull request
May 15, 2018
Bug Fixes * Ensure compatibility with recent versions of futures/enum34 eregs#516 * Avoid 500 when missing data eregs#515 (thanks to first time contributor, @lbeaufort!) * Fix bug which would turn §ion links into §
Merged
lbeaufort
added a commit
to fecgov/fec-eregs
that referenced
this pull request
May 15, 2018
- New version 8.4.2 now throws 404 errors instead of 500 errors for missing regulations (eregs/regulations-site#515) - This will address fec-eregs #385: 404 instead of 500 for missing regulations
lbeaufort
added a commit
to fecgov/fec-eregs
that referenced
this pull request
May 15, 2018
- New version 8.4.2 now throws 404 errors instead of 500 errors for missing regulations (eregs/regulations-site#515) - This will address fec-eregs #385: 404 instead of 500 for missing regulations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error handling for missing regulations
Addresses issue Missing data leads to an explosion #485: Missing data leads to an explosion
Also addresses FEC issue: 404 instead of 500s for bad calls in eRegs fecgov/fec-eregs#385
Throw a 404 error when navigating to a regulation that doesn't exist
Previously, the
utils.regulation_metafunction was returning{}, so accessing the 'meta' data was resulting in a 500 errorAllow site to respond to all hosts
ALLOWED_HOSTSmanually.