-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOTE MERGE] Zebra stripes by election and hide dropdown option #6597
[DO NOTE MERGE] Zebra stripes by election and hide dropdown option #6597
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6597 +/- ##
========================================
Coverage 79.91% 79.91%
========================================
Files 235 235
Lines 5147 5148 +1
========================================
+ Hits 4113 4114 +1
Misses 1034 1034 ☔ View full report in Codecov by Sentry. |
FieldPanel('reporting_dates_table', help_text='Zebra striping Tip: To add additional row classes for more granular cotrol over zebra stripes, wrap \ | ||
the election name text in first column/first cell with an <election> html tag. \ | ||
Example (includiing footnote tilda ): <election class="fl1">Florida 1st Congressional District Special Primary</election> ~*'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being help text, can we lowercase 'Tip', remove an i from includiing
, add an 'n' in 'cotrol', and change tilda )
to tilde)
. As a nice touch, I'd like to monospace the code in help_text but it doesn't seem like Wagtail supports that. Yet?
I'd want to verify with Content that the help text addresses questions they may have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfultz I definitely see how this might seem like overkill. But this template is only used by one team member now and becomes increasingly esoteric with each iteration. So I want to be explicit about this non-intuitive functionality for the current user and the eventual new user, someday.
mql.addListener(this.mediaQueryResponse); // TODO: .addListener() has been deprecated | ||
// See: https://developer.mozilla.org/en-US/docs/Web/API/MediaQueryList/addListener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Closing in favor of PR to release |
Summary (required)
NOTE: To avoid conflicts, please merge this related PR first: #6512
ReportngDatesTable template
more granular comtrol over Zebra striping by enabling the ability to add custom classes to rows in the table block.states dropdown
on the template instead of having to add CSS the template in an HTML block.Required reviewers
one dev and @djgarr - ( I can push to feature when you are ready)
Impacted areas of the application
zebra striping options ReportingDatesTable templates
States dropdown on ReportingDatesTable templates
How to test
I can push to feature when you are ready to test @djgarr
npm run build-js
Reporting dates table
template<election>
html tag, like:<election class="fl1">Florida 1st Congressional District Special Primary</election>
<tr class="fl1 fl">
<election>
tag in an<a>
link tag<a href="https://www.fec.gov/help-candidates-and-committees/dates-and-deadlines/2024-reporting-dates/prior-notices-2024/election-report-notice-florida/"><election class="fl1">Florida 1st Congressional District Special Primary</election></a>
System architecture updates (if applicable)
(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)