Remove legacy reporting dates JS #6512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
patphongs
changed the title
johnnyporkchops
changed the title
rfultz
reviewed
Jan 7, 2025
| @@ -11,7 +11,7 @@ const states_dropdown_template = ` | |||
| <option value="CO">Colorado</option> | |||
| <option value="CT">Connecticut</option> | |||
| <option value="DE">Delaware</option> | |||
| <option value="DC">District Of Columbia</option> | |||
| <option value="DC">District of Columbia</option> | |||
| @@ -164,49 +168,26 @@ ReportingDates.prototype.buildStaticElements = function() { | |||
|
|
|||
| table_parent.insertBefore(dropdown_wrapper, this.dates_table); | |||
|
|
|||
| //Create static footnote/header note list | |||
| //Create header note list for modal dialogue | |||
| let hdr_str = ''; | |||
There was a problem hiding this comment.
Can we run the formatter on this file to fix the indentation spacing and spaces between functions' ){
| ReportingDates.prototype.handleStateChange = function() { | ||
| const state = this.states.value.toLowerCase(); | ||
|
|
||
| //TODO: Should this be `this.dates_table.querySelectorAll` ? |
There was a problem hiding this comment.
If it works, I always prefer more specific selectors. In this case, 'tr' would grab all rows on every table of the page, good or bad. 'tr.footnote_row' would likewise grab every tr with that class, in every table on the page
| const date_sups = document.querySelectorAll('td sup'); | ||
|
|
||
| if (typeof footnotes_array == 'object') { |
There was a problem hiding this comment.
Do we need to handle the else here or just skip them it's not an object? (Hasn't typeof been tricky lately, identifying Arrays as objects, too?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
NOTE: Please merge this PR before merging #6597
Resolves Tech-debt: Remove reporting-dates-tables.js by converting legacy tables to use new template and JS #6491
Remove the legacy
eporting-dates-tables.jsRename the new
election-reporting-dates-tables.jstoreporting-dates-tables.jsso template and JS files have the same name for clarityRemove references to JS in
full_width_page.htmlRequired reviewers
one frontend and optionally one content (@djgarr)
Impacted areas of the application
Reporting dates tables from 2020 to present
deleted: fec/static/js/pages/election-reporting-dates-tables.js
modified: fec/static/js/pages/reporting-dates-tables.js
modified: home/templates/home/full_width_page.html
modified: home/templates/home/reporting_dates_table.html
Related issues/PRs
Issues:
#5153
PRs:
New:
#5786
#5798
Legacy:
#3227
How to test
npm run build-jsreporting_dates_table.htmlfor JS functionality (footnotes, state dropdown, header notes)http://127.0.0.1:8000/ /help-candidates-and-committees/dates-and-deadlines/2020-reporting-dates/electioneering-communications-periods-special-elections-2020/