Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 new categories to OIG reports #4837

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

patphongs
Copy link
Member

Summary

Adds 2 new categories to the OIG report options: "Investigations", "Other reports and plans".

Required reviewers

1 content, 1 front end

Impacted areas of the application

General components of the application that this PR will affect:

  • OIG reports page

Screenshots

In website

Screen Shot 2021-08-18 at 10 43 15 AM

In Wagtail

Screen Shot 2021-08-18 at 10 40 21 AM

How to test

For content reviewers

  • Inspect that the screenshot above looks good for the OIG dropdown on the website and in Wagtail.

For developers

  • checkout this branch
  • ./manage.py migrate - There's one migration file associated since there was a category change
  • ./manage.py runserver
  • Ensure that a report can be changed to a category "Investigations" or "Other reports and plans". Save and publish.
  • Ensure that the report can be filtered by either "Investigations" or "Other reports and plans" on their reports page: http://localhost:8000/about/reports-about-fec/oig-reports/

Copy link
Contributor

@dorothyyeager dorothyyeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question - Drop down looks good for OIG page

For Wagtail, I notice on the document menu page you see all the options, including the ones that don't apply to OIG. If that's not something we can configure for OIG, would recommend just putting all the options in alphabetical order or if there's a way to group the ones they can do at the top, and then somehow disable the rest. Not sure if this is doable but happy to do a call to explain.

@dorothyyeager
Copy link
Contributor

After checking with @patphongs, we'll open a separate ticket for the question I raised above.

Copy link
Contributor

@johnnyporkchops johnnyporkchops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I was able to change report category in Wagtail and filter on reports web page. Worked for creating an OIG report as both a DocumentPage and ResourcePage.

@johnnyporkchops johnnyporkchops merged commit 739dd03 into develop Aug 27, 2021
@lbeaufort lbeaufort deleted the feature/4813-add-oig-categories branch October 20, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "investigations" and "other reports" categories to OIG reports page
3 participants