Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude hearings from open mtg tab/fix open mtg search #4466

Merged

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Mar 10, 2021

Summary (required)

Change open meeting query to include only open meetings and also to exclude those Hearings pages made using meeting type 'O' (open meeting) by excluding by existence of 'hearing' (case insensitive) in title.

Limit open meetings free text search to only open meetings

Impacted areas of the application

modified: home/views.py

Screenshot

Mar-11-2021 02-19-27

How to test

  • checkout and run feature/4349/exclude-hearings-from-open-mtg-tab
  • Make sure no hearings show up in Open meetings tab
  • Make sure Hearings pages made with with incorrect meeting type of 'O', like September 14, 2017 audit hearing, don't show up in Open meeings tab
  • Search for Oklahoma democratic party in open meetings tab and confirm results contain those keywords
  • Note: in rare instances, Imported html for meetings before May 2017 may have commented-out html that can cause a search result for a keywords that are hidden on the rendered page. Example: search 'hearing ' on open meeting tab and you get a result for March 16, 2016 that does not show the word 'hearing' in the body text (it is in commented html)

Here is the example if incorrectly labeled Hearing in Wagtail:
http://127.0.0.1:8000/admin/pages/9257/edit/


@johnnyporkchops johnnyporkchops changed the title Exclude hearings from open mtg tab Exclude hearings from open mtg tab/fix open mtg search Mar 11, 2021
@JonellaCulmer
Copy link
Contributor

@johnnyporkchops We seem to be missing two of the public hearings on local. That won't be a problem for production, will it? I'm assuming the production site is ahead of your PR, correct?

@johnnyporkchops
Copy link
Contributor Author

johnnyporkchops commented Mar 19, 2021

@JonellaCulmer , Yes, that's expected, your local database would be behind production. If you wanted to update your local database with the latest, I can pair with you on it.
I assume its the two 2021 hearings that were likely added since you have done a local database update.

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thanks so much, @johnnyporkchops

@JonellaCulmer JonellaCulmer merged commit 24470b6 into develop Mar 19, 2021
@lbeaufort lbeaufort deleted the feature/4349/exclude-hearings-from-open-mtg-tab branch June 22, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants