Fix try fec.gov btn on legal no-results page

[johnnyporkchops]

Summary

Point Try FEC.gov link on legal search no-results page to fec.gov search, passing the search query

• Resolves Fix "try fec.gov" link on legal search "no results" message #3618

Impacted areas of the application

modified: legal/templates/macros/legal.jinja
modified: fec/static/js/legal/SearchResults.js
modified: legal/templates/layouts/legal-doc-search-results.jinja

Screenshots

How to test

checkout feature/fix-try-fec-link-legal-srch

Runserver:

• Go to: http://127.0.0.1:8000/data/legal/search/?search_type=all
• Type in a nonsense search string
• Click on Try FEC.gov button
• Confirm that it goes to the main fec.gov search page, passing your query along
• Also test :
  • http://localhost:8000/data/legal/search/enforcement/ , - - - --
  • http://localhost:8000/data/legal/search/advisory-opinions/?type=advisory_opinions&ao_category=F
  • http://localhost:8000/data/legal/search/statutes/
  • http://localhost:8000/data/legal/search/regulations/

---

[lbeaufort]

The example you provided works great, but I see two more places this search04 link is used in the code.

Examples (not sure this is comprehensive)

• MUR search http://127.0.0.1:8000/data/legal/search/murs/?search_type=murs&search=jabberwocky&case_no=&case_respondents=&case_min_open_date=&case_max_open_date=&case_min_close_date=&case_max_close_date=
• Statutes http://127.0.0.1:8000/data/legal/search/statutes/?search_type=statutes&search=jabberwocky

[johnnyporkchops]

@lbeaufort , I changed the link to global search in the other two places.

• This link only shows when one types a keyword search.
• For the legal-landing global searches, it always shows because this is essentially a one-field keyword search.
• For the AO datatable that uses searchResults.js, I had to remove the part that echos the search term in the error message because, since it's react, it would update in place as a user types a NEW search term--essentially printing a message to the screen saying "We found no documents matching "the new search term(s)" before the search is performed, regardless of whether the NEW term returns results. This would be confusing to the user.

[lbeaufort]

Great work, thanks for helping me review!