Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing migrations for internal/external button model changes #3411

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

patphongs
Copy link
Member

Summary (required)

There was a missing migration when the internal and external button additions were made for the records page. See referenced PR: #3338. This PR backfills the missing migration file that were introduced in the 20191126 release.

I ran a diff between the migration file up on the cloud CMS server (dev-cloud-migration-107.txt) against the generated migration file in this PR and it matches exactly. So it should be safe to merge this migration with all the others.

Impacted areas of the application

List general components of the application that this PR will affect:

  • Django migrations for internal/external buttons in record template

Related PRs

List related PRs against other branches:

branch PR
feature/2935-internal-external-link-record-and-example-templates link
release/public-20191126 link

How to test

  • Check out develop
  • Run ./manage.py makemigrations
  • Ensure that those migrations match what is in this PR

Copy link
Contributor

@johnnyporkchops johnnyporkchops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great detective work @patphongs.

@johnnyporkchops johnnyporkchops merged commit 096e100 into develop Dec 13, 2019
@lbeaufort lbeaufort deleted the feature/add-missing-migration-107 branch December 16, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants