Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal/external links to RecordPage template #3338

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Nov 7, 2019

Summary

The RecordPage model inherits from ContentPage model which uses stream_factory as its body section. So I added internal and external link buttons here.

Impacted areas of the application

This will effect all page models inheriting from ContentPage model, but only to the extent that they will now also have the new internal and external link buttons in their body streamfield.

  • modified: home/models.py

Screenshots

Screen Shot 2019-11-07 at 12 11 55 PM

Related PRs

#3149:

How to test

  • Checkout and run branch
  • Create page of type, RecordPage and confirm and test the external and internal link buttons
  • Publish or Preview to confirm it works

@codecov-io
Copy link

Codecov Report

Merging #3338 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3338   +/-   ##
========================================
  Coverage    74.59%   74.59%           
========================================
  Files          120      120           
  Lines         7232     7232           
  Branches       634      634           
========================================
  Hits          5395     5395           
  Misses        1837     1837
Impacted Files Coverage Δ
fec/home/models.py 87.53% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39978f...b59697b. Read the comment docs.

@johnnyporkchops
Copy link
Contributor Author

@dorothyyeager , this is on feature for testing

@dorothyyeager
Copy link
Contributor

Loving it! The Record articles are going to look so much better. I tested both buttons on one and here's how they turned out... (perfect!)
image

Copy link
Contributor

@dorothyyeager dorothyyeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are AWESOME and I love that they're enabled not just for Record pages, but also the Press templates and the tips template. They'll add some visual punch to those often link-heavy pages. Thank you so much for doing this! Approved from content team perspective.

@dorothyyeager dorothyyeager merged commit f7356e8 into develop Nov 7, 2019
@dorothyyeager dorothyyeager deleted the feature/2935-internal-external-link-record-and-example-templates branch November 7, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wagtail wish list: Add internal and external link buttons to Record and Example page templates
3 participants