Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WCCF PR H elections to four years #3329

Merged
merged 3 commits into from
Nov 14, 2019

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Nov 6, 2019

Summary

Impacted areas of the application

Only WCCF, and only the method that builds the URLs for the state totals' links.

Screenshots

None

Related PRs

None

How to test

  • Pull, npm i, npm run build, ./manage.py runserver
  • Check WCCF for House candidates with contributions that come from Puerto Rico (Gonzalez Colon, Jenniffer is a 2020 candidate with data)
  • Find the Puerto Rico line item
  • Hover over the linked dollar amount to check that two appropriate two_year_transaction_period params are present
  • Hover over another state or two to make sure there's only one value for two_year_transaction_period
  • Check a presidential election that every state has two values for two_year_transaction_period
  • Check a Senate election to make sure every state has three values for two_year_transaction_period
  • If you're the last approval, merge, delete

@codecov-io
Copy link

Codecov Report

Merging #3329 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3329   +/-   ##
========================================
  Coverage    74.59%   74.59%           
========================================
  Files          120      120           
  Lines         7232     7232           
  Branches       634      634           
========================================
  Hits          5395     5395           
  Misses        1837     1837

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39978f...fee22b9. Read the comment docs.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @rfultz

@JonellaCulmer JonellaCulmer removed the request for review from johnnyporkchops November 14, 2019 15:40
@patphongs patphongs merged commit 40336a7 into develop Nov 14, 2019
@lbeaufort lbeaufort deleted the feature/3290-wccf-puerto-rico-house-four-years branch November 29, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puerto Rico clickthrough on WCCF not linking to 4 year total
3 participants