-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pre-election tables, stripe rows by state #3288
Conversation
@johnnyporkchops We just noticed that |
Codecov Report
@@ Coverage Diff @@
## develop #3288 +/- ##
==========================================
+ Coverage 74.6% 74.6% +<.01%
==========================================
Files 120 120
Lines 7194 7195 +1
Branches 633 634 +1
==========================================
+ Hits 5367 5368 +1
Misses 1827 1827
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @johnnyporkchops and @rfultz. i see where to change it in the spreadsheet and have made it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @johnnyporkchops!
Summary (required)
Stripe table rows by state instead of zebra striping (Issue 3017)
Show state footnotes (first-column) under row (Issue 3263)
Resolves #3017
Also Resolves #3263
Impacted areas of the application
Pre-election reporting dates tables
modified: fec/static/js/pages/reporting-dates-tables.js
modified: fec/static/scss/components/_table-styles.scss
Note: This PR also includes two files from PR #3206 that where formatted when running
npm format-lint
and the PR author (@patphongs) directed me to push them up with this PR. They may have bypassed linting because apparently,npm lint
is less strict thannpm format-lint
.modified: fec/static/js/modules/filters/filter-typeahead.js
modified: fec/static/js/modules/filters/typeahead-filter.js
Related PRs
#3227
#3248
Screenshots
How to test
npm run build
./manage.py runserver
127.0.0.1/admin
FullWidthPage
Sample text to copy/paste
section below. This step simulates the content team members copy/pasting from Excel but leaves out the actual spreadsheet part here.Sample text to copy/paste (click to expand)
—————————————
Table html: Paste into Wagtail html block
—————————————
—————————————
Footnotes object: Paste into Wagtail html block
—————————————
—————————————
Header Notes object: Paste into Wagtail html block
—————————————