-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape special chars #3206
Escape special chars #3206
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3206 +/- ##
===========================================
+ Coverage 74.6% 74.61% +<.01%
===========================================
Files 120 120
Lines 7160 7162 +2
Branches 633 633
===========================================
+ Hits 5342 5344 +2
Misses 1818 1818
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented with screenshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried several OWASP evasion techniques and did not find any issues. Also the typeahead seems to work fine now to escape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good—thanks for untangling this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @patphongs! I tested several datatables and they look good to me.
See ticket for instructions on how to test: https://github.com/fecgov/fec-accounts/issues/213#issuecomment-536076501