Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3232 wccf committee api call #3233

Merged
merged 3 commits into from
Oct 4, 2019

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Oct 4, 2019

Summary

Impacted areas of the application

  • Only that one query/fetch in this one widget

Screenshots

No visible changes

Related PRs

There are several other WCCF PRs but none that help or hinder this issue.

How to test

  • Pull, build, and run this branch like always.
  • Check that we gets lists of states data (The committee call is after the candidate details but before the list of states).
  • Check that the numbers agree with the individual contributions pages of the same data.
  • All approved? Merge and delete the branch.

Note: this PR does not include any of the other WCCF work. The states may be odd colors. The legend may have outdated labels. The Indiv Contribs links may or may not be linking correctly.


@codecov-io
Copy link

Codecov Report

Merging #3233 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #3233   +/-   ##
=======================================
  Coverage     74.6%   74.6%           
=======================================
  Files          120     120           
  Lines         7160    7160           
  Branches       633     633           
=======================================
  Hits          5342    5342           
  Misses        1818    1818

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c88715...254ffdd. Read the comment docs.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the call! It matches the candidate profile page now

@patphongs patphongs merged commit 14fa6c1 into develop Oct 4, 2019
@lbeaufort lbeaufort deleted the feature/3232-wccf-committee-api-call branch October 7, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCCF: Make individual contribution committee api call consistent
3 participants