Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCCF: Make individual contribution committee api call consistent #3232

Closed
1 task
Tracked by #156
patphongs opened this issue Oct 4, 2019 · 3 comments · Fixed by #3233
Closed
1 task
Tracked by #156

WCCF: Make individual contribution committee api call consistent #3232

patphongs opened this issue Oct 4, 2019 · 3 comments · Fixed by #3233
Assignees
Milestone

Comments

@patphongs
Copy link
Member

patphongs commented Oct 4, 2019

Summary

The API call that is used in the Where contributions come from map should be consistent with the one we are using on the candidate profile page. We need to change the call to include /history/ like this:
/candidate/[committee_id]/committees/history/[cycle]?per_page=100&API_KEY=[key]&designation=P&designation=A&election_full=true

Completion criteria

  • Check the committees link on the Where contributions come from "Browse individual contributions" button link and the individual state dollar figure links now use the updated API call
@patphongs patphongs added this to the Sprint 10.2 milestone Oct 4, 2019
@rfultz
Copy link
Contributor

rfultz commented Oct 4, 2019

Should I add /[election_year]/ to the query, too, or keep it as a parameter (cycle)?

@patphongs
Copy link
Member Author

patphongs commented Oct 4, 2019

@rfultz You should be able to keep it as cycle since we are passing election_full=true, that should take care of getting the full election years worth of committees. I'll update the issue

@patphongs
Copy link
Member Author

Sorry @rfultz, I mis-interpreted this endpoint. You'll need to put cycle as part of the endpoint path and not as a query param. It doesn't seem to take cycle in that way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants