Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due by July 22nd] Add new data summary language to various pages #3067

Merged

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Jul 19, 2019

Summary (required)

This ticket adds this new language ("Newly filed summary data may not appear for up to 48 hours.") to several places across the site.

Impacted areas of the application

List general components of the application that this PR will affect:
fec/data/templates/macros/bythenumbers.jinja
fec/data/templates/macros/disclaimer.jinja
fec/data/templates/macros/tables.jinja
fec/data/templates/partials/browse-data/raising.jinja
fec/data/templates/partials/browse-data/spending.jinja
fec/data/templates/partials/candidate/other-spending-tab.jinja
fec/data/templates/partials/candidate/raising.jinja
fec/data/templates/partials/candidate/spending.jinja
fec/data/templates/partials/candidates-office-filter.jinja
fec/data/templates/partials/committee/financial-summary.jinja
fec/data/templates/partials/committee/raising.jinja
fec/data/templates/partials/committee/spending.jinja
fec/fec/static/scss/layout/_layout.scss

How to test

  • checkout feature/3040-new-data-summary-language
  • npm run-build
  • Compare these pages to the mockups on Issue 3040 to ensure that the new language is there and presented properly.
  • These are all linked with http://127.0.0.1:8000 as the URL base, for local testing:

Data tables:

Visualizations:

Candidate profile pages:

Committee profile pages:

@johnnyporkchops johnnyporkchops changed the title Add new data summary language to various pages [Due by July 22nd] Add new data summary language to various pages Jul 19, 2019
@johnnyporkchops johnnyporkchops changed the base branch from develop to release/public-20190723 July 19, 2019 21:46
@codecov-io
Copy link

Codecov Report

Merging #3067 into release/public-20190723 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           release/public-20190723    #3067   +/-   ##
========================================================
  Coverage                    74.86%   74.86%           
========================================================
  Files                          119      119           
  Lines                         7137     7137           
  Branches                       618      618           
========================================================
  Hits                          5343     5343           
  Misses                        1794     1794

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83b933...17b2c99. Read the comment docs.

@JonellaCulmer
Copy link
Contributor

@johnnyporkchops The only place I'm not seeing the new language is on the aggregate totals boxes on the raising and spending by the numbers pages.

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @johnnyporkchops. Merging...

@patphongs patphongs merged commit 22ae197 into release/public-20190723 Jul 22, 2019
@lbeaufort lbeaufort deleted the feature/3040-new-data-summary-language branch October 25, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants