Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MUR date filter #3036

Merged
merged 6 commits into from
Jul 10, 2019
Merged

Add MUR date filter #3036

merged 6 commits into from
Jul 10, 2019

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented Jul 10, 2019

Summary (required)

TODO in future ticket:
Page still refreshes every time a query is submitted or the page paginates. There are future enhancements we'll need to make in order to update this. Ticket has been created here: #3037

Impacted areas of the application

List general components of the application that this PR will affect:

Side note: I needed to update the ADRs and Admin Fines datatable templates in order to get the filters indented correctly whenever we do add accordions into the page. This should not change too much visually for those tables except for slight padding up at the top, but still worth checking against feature.

For these pages, you'll need to turn on those feature flags:
export FEC_FEATURE_ADRS=true and export FEC_FEATURE_AFS=true

Screenshots

Screen Shot 2019-07-10 at 2 39 57 PM

How to test

  1. Check out this branch: feature/2969-mur-date-filter. These are pure python related changes, so you don't really need to do any builds. But it doesn't hurt to do it if you want to npm run build.
  2. Go to http://localhost:8000/data/legal/search/murs/
  3. Try performing some date range searching for both CASE OPEN DATE RANGE and CASE CLOSE DATE RANGE. Make sure the results are updating as expected.

@codecov-io
Copy link

Codecov Report

Merging #3036 into develop will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3036      +/-   ##
===========================================
- Coverage     74.9%   74.86%   -0.05%     
===========================================
  Files          119      119              
  Lines         7133     7137       +4     
  Branches       618      618              
===========================================
  Hits          5343     5343              
- Misses        1790     1794       +4
Impacted Files Coverage Δ
fec/legal/views.py 46.31% <0%> (-2.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d99811...aaca81e. Read the comment docs.

Copy link
Contributor

@rfultz rfultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I'd like the date fields to automatically add the slashes instead of returning no results but that may be outside the scope of this issue

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great. I received the results I expected.

@JonellaCulmer JonellaCulmer merged commit 79fabd9 into develop Jul 10, 2019
@lbeaufort lbeaufort deleted the feature/2969-mur-date-filter branch July 10, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MUR filter to datatable
4 participants