-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MUR date filter #3036
Add MUR date filter #3036
Conversation
…n, re-order Date opened and Date closed in search results
…on styling to MURs
… enhancements are made.
Codecov Report
@@ Coverage Diff @@
## develop #3036 +/- ##
===========================================
- Coverage 74.9% 74.86% -0.05%
===========================================
Files 119 119
Lines 7133 7137 +4
Branches 618 618
===========================================
Hits 5343 5343
- Misses 1790 1794 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I'd like the date fields to automatically add the slashes instead of returning no results but that may be outside the scope of this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great. I received the results I expected.
Summary (required)
This adds new case open and case close date range filters to the MUR datatable search.
TODO in future ticket:
Page still refreshes every time a query is submitted or the page paginates. There are future enhancements we'll need to make in order to update this. Ticket has been created here: #3037
Impacted areas of the application
List general components of the application that this PR will affect:
Side note: I needed to update the ADRs and Admin Fines datatable templates in order to get the filters indented correctly whenever we do add accordions into the page. This should not change too much visually for those tables except for slight padding up at the top, but still worth checking against feature.
For these pages, you'll need to turn on those feature flags:
export FEC_FEATURE_ADRS=true
andexport FEC_FEATURE_AFS=true
Screenshots
How to test
npm run build
.CASE OPEN DATE RANGE
andCASE CLOSE DATE RANGE
. Make sure the results are updating as expected.