-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MUR filter to datatable #2969
Comments
Initial thoughts from content perspective:
So I think for re-wording "Violation Time Period" (which I think does need re-wording), I'd suggest "Case Time Frame (Year(s))." @AmyKort thoughts? As far as how you would search for it, I'll take my cues from MUR 7586 again. That case began for the FEC in 2018 when the trade association involved filed a sua sponte complaint to report itself for violations. According to the First General Counsel's Report, the violations began in 2012 and were discovered in 2016 by the trade association. From perspective of someone who searches for these kinds of cases, I'd be looking for "if/when" the case is closed. But if I know that it could be anywhere between 2012 and 2018, I'd want the option to put all of those years in. So there's a question - do we want the MUR search to return the years covered by the case or the years that FEC documents are available? In the case of the MUR above, the years covered are 2012 through 2019. FEC documents are dated 2018 and 2019. I hope this is helpful @JonellaCulmer ! Let me know if you need anything more content-team-wise. (Edited because I tagged the wrong jculmer at first; sorry!) |
I think that was the request--being able to look up a MUR based on the time frame you think the MUR was opened or closed--just a way to narrow your search. We could see how much that helps users, and we might be able to build on that knowledge to make a smarter filter later. Thoughts @JonellaCulmer and @dorothyyeager ? |
@AmyKort I'm good with that, and in that case, all we really need are the two boxes in your comment above (Case close date and case open date). |
Sounds good. Updated mockup below. @AmyKort @dorothyyeager |
@lbeaufort Do you think you have any reason to believe that the previous API work that was done on this can't support the latest mock-up - showing Case open date and Case close date? |
No reason to believe, thanks for checking. Open date example Close date example |
@patphongs Please see the updated mockup below based on our discussion to add a bit more clarity and consistency with our other date filters. |
I've got the logic for the MUR date filter working. The Accordions are giving me trouble though, need to try to resolve the styling in the templates. |
What we're after: Following the design work here and the discussion here , we need to add time period filters to the MUR search.
The API work is done: #1533 (comment)
Completion criteria:
Confirm/determine whether it's a single year or two-year period that we need to search byMockups
The text was updated successfully, but these errors were encountered: