Creating MUR filter for date opened and date closed

[jenniferthibault]

@AmyKort commented on Thu Sep 28 2017

Users searching our MUR holdings still have difficulty searching MURs opened or closed during specific time periods. We need to add a filter option to allow users to set date opened and date closed filters for MURs.

Jen may already have much of this work completed.

• create the filter

---

@jenniferthibault commented on Tue Oct 03 2017

🕵️‍♀️ GitHub archeology is one of my favorite things because I get to rediscover the awesome work and thinking our teammates have already done!

Nicky documented the most up-to-date filter designs and concepts for MURs, ADRs, and Admin fines in fecgov/openFEC-web-app#1797 (comment) This will be a good issue to keep handy.

Pulling out the MUR filters specifically, and zooming in on the time period concepts, the question in orange was a content design question about the field label:

@xtine can you help assess if the components on the API/back end are in place for the case data & violation date concepts to work?

---

@jenniferthibault commented on Tue Oct 10 2017

Rebumping to @xtine for taking a look at the front end needs 👋

---

@lbeaufort commented on Tue Oct 17 2017

@jenniferthibault if it's not too much work, there were two recent requests to add MUR number to the search, like the AO search:

https://github.com/18F/FEC/issues/4583
https://github.com/18F/FEC/issues/4460

---

@AmyKort commented on Tue Oct 17 2017

I think we've had that functionality for a while, but it was difficult to find https://www.fec.gov/data/legal/search/enforcement/?search=&search_type=murs

Am I misunderstanding @jenniferthibault ? (because that has been the theme of my day) Are you suggesting we integrate the filters differently?

---

@lbeaufort commented on Tue Oct 17 2017

@AmyKort @jenniferthibault Sorry I was unclear - I think the request was to make it easier to find, or on the search landing page, similar to the AO search (below). I met a new EA today who mentioned she had recently submitted feedback, and when I was looking through the feedback I discovered two requests for MUR number search that I thought could have come from our internal users.

---

@AmyKort commented on Tue Oct 17 2017

Super! Thanks @lbeaufort !

---

@jenniferthibault commented on Tue Oct 17 2017

@lbeaufort what you're looking for has already been added via https://github.com/18F/fec-cms/pull/1276 and you can take a look on staging. It will go out with the release. 🎉

This issue is about adding the date opened/closed filters to the actual full filter list available in the advanced MUR search sidebar, at this link: https://www.fec.gov/data/legal/search/enforcement/?search_type=murs

And will be seen here:

This is a piece of an issue where we had all the research and designs for the full filter list finished a long time ago, (check them out in fecgov/openFEC-web-app#1797 (comment)!) but haven't had the engineering support available to implement them, so we're adding them piece by piece.

Does that clear things up am I misunderstanding and adding more confusion?

---

@jenniferthibault commented on Tue Oct 17 2017

PS: @lbeaufort this is also a good reminder using my own bad example: no matter how "urgent" the fix or how inexperienced the dev (me, in this case!) including a proper pull request description and linking the PR to existing issues filed is a core part of working in the open and documenting what/how/why we're making these changes. Thanks you for training the trainers 😄

---

@lbeaufort commented on Wed Oct 18 2017

@jenniferthibault That is awesome, thanks!

---

@AmyKort commented on Wed Oct 25 2017

cc @johnnyporkchops

---

@jenniferthibault commented on Mon Oct 30 2017

Thanks to @lbeaufort 's awesome demo today, it looks like
her pull request https://github.com/18F/openFEC/pull/2712 adds the work that makes this information available to use on the front end via a change to the endpoint. (I think, but may be misrepresenting.)

So if it's available, this is a front end implementation issue to add the feature to the MUR search filters!

[lbeaufort]

@xtine - I think the date filter on the AO search may be helpful here:

API MUR date fields are:

mur_min_open_date
mur_max_open_date
mur_min_close_date
mur_max_close_date

AO advanced search options
https://www.fec.gov/data/legal/search/advisory-opinions/?type=advisory_opinions&ao_category=F

[lbeaufort]

Here, maybe? https://github.com/18F/fec-cms/blob/develop/fec/fec/static/js/legal/Filters.js

[lbeaufort]

Note: MURs aren't using react - just a form submit.

[lbeaufort]

@PaulClark2 I think this work is still important.

[lbeaufort]

We're addressing this in PI 9

[JonellaCulmer]

I've updated the filter panel to show what it would/should look like with the time periods built in.

[lbeaufort]

Thanks @JonellaCulmer!

Not all MURs are violations... we could take a cue from the classic site labels or the api. The api has a “case election cycles”, but I’m not sure if that always has data. For MURs we aren’t required to choose a year - we can take a look at the data.

https://api.open.fec.gov/developers/#/legal/get_legal_search_

[JonellaCulmer]

Closing in favor of this new issue: #2969