Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge After openFEC #PR3536]Update the committee profile pages for EC filers #2546

Merged
merged 3 commits into from
Dec 17, 2018

Conversation

pkfec
Copy link
Contributor

@pkfec pkfec commented Nov 28, 2018

Summary (required)

Impacted areas of the application

  • C3 filer profile pages
  • Spending, Filing sections of this filer

Screenshots

About the filer section:
screen shot 2018-11-27 at 9 31 13 pm

Spending section:
screen shot 2018-11-27 at 9 34 14 pm
screen shot 2018-11-27 at 9 34 24 pm

Filing section:
screen shot 2018-11-27 at 9 38 07 pm
screen shot 2018-11-27 at 9 38 16 pm

How to test

  1. checkout the branch feature/update-ec-filer-committee-profile-template

  2. point the local cms server to dev api

  3. start the server

  4. For EC filers :click below links to see changes made on the Section and subsections on the left hand side menu( About the filer, Spending, Filings etc..)

  5. Test any non EC committee to make sure the Sections and subsections on the left hand menu appear for given committee.

@pkfec pkfec force-pushed the feature/update-ec-filer-committee-profile-template branch from 81e8445 to f387504 Compare November 28, 2018 02:50
@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #2546 into develop will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2546      +/-   ##
==========================================
- Coverage    75.03%   74.9%   -0.14%     
==========================================
  Files          115     113       -2     
  Lines         6975    6934      -41     
  Branches       599     599              
==========================================
- Hits          5234    5194      -40     
+ Misses        1741    1740       -1
Impacted Files Coverage Δ
fec/fec/static/js/modules/toc.js 87.17% <0%> (-12.83%) ⬇️
fec/fec/urls.py 72.72% <0%> (-4.55%) ⬇️
fec/fec/settings/production.py 0% <0%> (ø) ⬆️
fec/fec/settings/dev.py 100% <0%> (ø) ⬆️
fec/fec/tests/test_robots.py
fec/fec/tests/test_static_files.py
fec/fec/settings/base.py 88.75% <0%> (+1.25%) ⬆️
fec/home/views.py 34.39% <0%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4db67...a01bf1c. Read the comment docs.

@pkfec pkfec changed the title [WIP]Update the committee profile pages for EC filers [Merge After openFEC #PR3535]Update the committee profile pages for EC filers Dec 13, 2018
Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkfec Your changes look really good, thanks for working on this. I just found one small thing. The section-5 div id should be within the data-container__wrapper. Because it's currently outside that wrapper, it is causing the navigation in the filings section to shift to full screen.

screen shot 2018-12-13 at 4 35 01 pm

@pkfec
Copy link
Contributor Author

pkfec commented Dec 14, 2018

@pat
An extra closing tag in spending.jinga template was causing the filings section show in full screen mode. @johnnyporkchops helped me figure this out. Thanks a bunch!

…ag is causing the navigation in the filings section to shift to full screen.
Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pkfec !

@patphongs patphongs merged commit 3f2ad57 into develop Dec 17, 2018
@pkfec pkfec changed the title [Merge After openFEC #PR3535]Update the committee profile pages for EC filers [Merge After openFEC #PR3536]Update the committee profile pages for EC filers Dec 17, 2018
@lbeaufort lbeaufort deleted the feature/update-ec-filer-committee-profile-template branch June 21, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants