-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merge After openFEC #PR3536]Update the committee profile pages for EC filers #2546
[Merge After openFEC #PR3536]Update the committee profile pages for EC filers #2546
Conversation
81e8445
to
f387504
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2546 +/- ##
==========================================
- Coverage 75.03% 74.9% -0.14%
==========================================
Files 115 113 -2
Lines 6975 6934 -41
Branches 599 599
==========================================
- Hits 5234 5194 -40
+ Misses 1741 1740 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkfec Your changes look really good, thanks for working on this. I just found one small thing. The section-5
div id should be within the data-container__wrapper
. Because it's currently outside that wrapper, it is causing the navigation in the filings section to shift to full screen.
@pat |
…ag is causing the navigation in the filings section to shift to full screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @pkfec !
Summary (required)
Impacted areas of the application
Screenshots
About the filer section:
Spending section:
Filing section:
How to test
checkout the branch
feature/update-ec-filer-committee-profile-template
point the local cms server to dev api
start the server
For EC filers :click below links to see changes made on the Section and subsections on the left hand side menu( About the filer, Spending, Filings etc..)
Test any non EC committee to make sure the Sections and subsections on the left hand menu appear for given committee.