Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "committee profile page" template used for EC filers #2301

Closed
10 tasks done
Tracked by #138
llienfec opened this issue Aug 22, 2018 · 7 comments
Closed
10 tasks done
Tracked by #138

Update "committee profile page" template used for EC filers #2301

llienfec opened this issue Aug 22, 2018 · 7 comments
Assignees
Milestone

Comments

@llienfec
Copy link
Contributor

llienfec commented Aug 22, 2018

We're currently using the main "committee profile page" information for electioneering communications filers; however, a lot of information doesn't apply to ECs. These changes affect filers with ID numbers that start with C3. Most of the suggestions below are because:

  • These are filers instead of committees
  • They don't file F1s or have "regularly filed reports"

If these changes are possible, we also need to review the C9 independent expenditure filers "committee profile pages." Those filers will need similar (but less extensive) updates.

Example committee: https://www.fec.gov/data/committee/C30001366/
Relevant committees: File on Form 9
Type: Electioneering communication committees
Committee ID: C3XXXXXXX

Completion criteria:

  • Investigate in the API whether we need to introduce new logic to distinguish between EC filers and other committees. (There are committee type C and we already do dynamically generate financial summary pages based on committee type. Check out get_committee view.)
  • Update the conditionals with the committees-single.jinja file to render what is described below
  • Implement changes in language and appearance suggested below

Additonal completion criteria by section:

Menu:

  • Change "About this committee" to "About this filer"
  • Under Spending, add s to "electioneering communication"

About this committee:

image

Spending

  • Within the description for the EC section and the disbursements section, indicate it's a disbursement by inserting the words "Any disbursement for a..."

  • Electioneering communications - switch the columns for all ECs information on committee profile pages
    image

  • Conditionally add candidate disbursement column in the table for only EC committee type pages. Column name should be "Candidate".
    image

Filings

  • Conditionally remove "regularly filed reports" and "Statements of organization" only for EC committee type pages.
  • Change "24- and 48-hour reports" to "24-hour reports"
    image
@patphongs
Copy link
Member

@llienfec We made a few technical changes to the completion criteria you laid out above, can you please double check?

@llienfec
Copy link
Contributor Author

@patphongs Looks good. I added in a criteria above to adjust the menu options under filing. Thanks so much for working on this!

@pkfec
Copy link
Contributor

pkfec commented Nov 20, 2018

I am conditionally hiding the links for EC committee type like mentioned in the ticket above. However, its not clear if we have to hide the Raising link and also hide or not show the Other documents under the Filings link.

@llienfec Can you please tell me how to proceed further?
cc @jwchumley

@llienfec
Copy link
Contributor Author

Hi @pkfec - I think we should hide the raising link. Keep the other documents link under filing. ECs may file something like a Form 99. I don't know why they would, but I think they're allowed to. So while it wouldn't be used often, it's safer to keep it visible.

Great questions! Let me know if this is unclear.

@pkfec
Copy link
Contributor

pkfec commented Nov 26, 2018

@llienfec Thank you! I will work on this.

@lbeaufort lbeaufort modified the milestones: Sprint 7.6, Sprint 7.7 Nov 26, 2018
@pkfec
Copy link
Contributor

pkfec commented Nov 28, 2018

The endpoint that returns the disbursements data for C3 filers is : v1/schedules/schedule_b/

The disbursement candidate info for C3 filers is not available in the DB. After looking at that C3 filers data, it appears that disbursement candidate information is never submitted on Form9.
I can still add the Candidate column to the Disbursements datatable, however there is NO DATA to display under this column. In this case should we still display the Candidate column?

Other C3 filers without Disbursement candidate information:
"C00009282"
"C30000012"
"C30000020"
"C30000038"
"C30000046"
"C30000053"
"C30000061"
"C30000079"
"C30000087"
"C30000095"
"C30000103"
"C30000111"
"C30000129"

Screenshot of Disbursements datatable for C30002885 after adding the Candidate column:

screen shot 2018-11-27 at 9 16 08 pm

API call:
https://api.open.fec.gov/v1/schedules/schedule_b/?sort_null_only=false&committee_id=C30002885&api_key=DEMO_KEY&two_year_transaction_period=2018&sort_hide_null=false&per_page=20&sort=-disbursement_date

JSON Screenshots without candidate information:
screen shot 2018-11-27 at 8 31 42 pm

screen shot 2018-11-27 at 8 31 10 pm

cc: @fecjjeng @jwchumley @PaulClark2

@pkfec
Copy link
Contributor

pkfec commented Dec 12, 2018

Disbursement Candidate information for EC filers is not available in SB endpoint. @PaulClark2 suggested that EC filers committee, disbursements candidate information can be obtained from /electioneering/ endpoint. However on the API, these two columns payee_name and payee_st are not mapped in the EC model which are required columns and are displayed in the disbursement section. I will open a new API ticket to map these two DB columns and update the EC model file.

SB api call:
https://api.open.fec.gov/v1/schedules/schedule_b/?sort_null_only=false&committee_id=C30002885&api_key=DEMO_KEY&two_year_transaction_period=2018&sort_hide_null=false&per_page=20&sort=-disbursement_date

/electioneering/ api call:
https://api.open.fec.gov/v1/electioneering/?sort_hide_null=false&committee_id=C30002885&page=1&per_page=20&api_key=DEMO_KEY&sort_nulls_last=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants