-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADR datatable page #2440
Add ADR datatable page #2440
Conversation
- add ADR filter page template - add ADR search results template - add url route for adrs - add ADR legal search results template to view
…respondent to coincide with the improvements made to the API
Codecov Report
@@ Coverage Diff @@
## develop #2440 +/- ##
===========================================
- Coverage 74.25% 74.23% -0.03%
===========================================
Files 111 111
Lines 6645 6659 +14
Branches 591 591
===========================================
+ Hits 4934 4943 +9
- Misses 1711 1716 +5
Continue to review full report at Codecov.
|
- expanded width of case column - added i-folder icon for ADR cases - formatted keyword return to be inline
- updated scope of results so that the ADR totals can be accessed
- Added ADR classic message - increased case column width by 10%
@JonellaCulmer The additional datatable items noted here: #2436 (comment) have been added to this PR. Please do another design review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, great! Thanks, @patphongs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @patphongs! I also think the results look great - nice design work @JonellaCulmer
Noting a small issue we discussed that shouldn't be a big issue - the ADR search says “keyword match” when we’re not searching on keywords:
I also confirmed that the feature flag worked properly - I did need to |
Thanks @lbeaufort. The feature flags are strange in that the environment setting is checking for the existence of the feature flag, so technically you can set it to anything (not necessarily a boolean) and it would work. That logic should probably be fixed at some point, it can be confusing. |
Summary
This adds ADR datatable page to the enforcement legal features.
How to test
vi ~/.bash_profile
and insert this feature flag for ADRsexport FEC_FEATURE_ADRS=true
Impacted areas of the application
List general components of the application that this PR will affect:
Screenshots