Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ADR datatable page #2436

Closed
1 of 3 tasks
Tracked by #139
patphongs opened this issue Oct 11, 2018 · 9 comments
Closed
1 of 3 tasks
Tracked by #139

Implement ADR datatable page #2436

patphongs opened this issue Oct 11, 2018 · 9 comments
Assignees
Labels
ADR/AF pages Implementation of ADR/AF pages on .gov Work: Front-end Work: UX/Design
Milestone

Comments

@patphongs
Copy link
Member

patphongs commented Oct 11, 2018

What we're after: Using the design created below and data moved to the API in 7.2, we want to begin to implement the front-end interface and canonical pages for the ADR pages.

We're basing this first iteration on the MUR pages currently implemented in production. See example linked above.

Updated mockup following conversations during design sync and dev pairing.
screen shot 2018-09-18 at 9 08 24 am

Completion criteria:

  • Make the ADR data table page.
  • Send to ADR for review.
  • Add feature flag for ADR data table page.
@patphongs
Copy link
Member Author

patphongs commented Oct 11, 2018

@JonellaCulmer I've got a couple of questions, we can go over it in design sync too:

  1. For the "Election cycle" column, we can't determine the general and primary election cycle attributes that you've included in your mock up. Is it needed? If so, we'll need an API change. https://fec-dev-api.app.cloud.gov/v1/legal/search?hits_returned=20&type=adrs&api_key=DEMO_KEY

  2. Looks like complaints can have multiple files, not sure how the complaints are used in this context.

  3. Do we have this file icon screen shot 2018-10-11 at 8 13 56 pm anywhere?

@patphongs
Copy link
Member Author

@JonellaCulmer Do we have this file icon screen shot 2018-10-11 at 8 13 56 pm anywhere?

@patphongs
Copy link
Member Author

patphongs commented Oct 12, 2018

@lbeaufort It appears that ADR number and ADR respondent is not filterable like it is for MURs?

ADR number filter:

This should just return ADR # 843: https://fec-dev-api.app.cloud.gov/v1/legal/search?adr_no=843&hits_returned=20&type=adrs&from_hit=0&api_key=DEMO_KEY

Similar to how this call returns just MUR # 843: https://fec-dev-api.app.cloud.gov/v1/legal/search?mur_no=843&hits_returned=20&type=murs&from_hit=0&api_key=DEMO_KEY

ADR respondent filter:

This should just return a few results for respondent keyword "martin": https://fec-dev-api.app.cloud.gov/v1/legal/search?adr_respondents=martin&hits_returned=20&type=adrs&from_hit=0&api_key=DEMO_KEY

Similar to how this call returns just respondent keyword "martin": https://fec-dev-api.app.cloud.gov/v1/legal/search?mur_respondents=martin&hits_returned=20&type=murs&from_hit=0&api_key=DEMO_KEY

@lbeaufort
Copy link
Member

@patphongs that’s correct. We’re moving to the more generic ‘case_’... filters.

@JonellaCulmer
Copy link
Contributor

@patphongs Here are some answers to your questions. Happy to discuss further during design sync

  1. For the "Election cycle" column, we can't determine the general and primary election cycle attributes that you've included in your mock up. Is it needed? If so, we'll need an API change. https://fec-dev-api.app.cloud.gov/v1/legal/search?hits_returned=20&type=adrs&api_key=DEMO_KEY
  • In some cases the -General or -Primary is included. It won't be in every case, only for those where it has been provided.
  1. Looks like complaints can have multiple files, not sure how the complaints are used in this context.
  • It doesn't necessarily need to be a complaint file that's used. The keyword match should yield a document that includes those terms. And I think we should limit it to one document.
  1. Do we have this file icon anywhere?
  • Yes, should be called .i-folder

@patphongs
Copy link
Member Author

  • election_cycles currently does not pull in election_cycle_type, so this would require an API change to append election_cycle_type to election_cycles.

@patphongs
Copy link
Member Author

patphongs commented Oct 12, 2018

As discussed in design sync, I will make the ADRs within this URL path: /legal-resources/enforcement/adrs-search. This is consistent with what we have for the audit search and will apply the same URL structure for other enforcement related paths in the future, see #2441

UPDATE:
I just found out that making this URL change for ADRs would effect all of the other legal search paths since the search call is all constructed using this function in the API caller:

def load_legal_search_results(query, query_type='all', offset=0, limit=20, **kwargs):
. Since that's the case, I don't want to make this URL change yet for ADRs and we can cover this change when we update all legal URLs across the board in this follow-up ticket: #2441

cc @JonellaCulmer @AmyKort

@patphongs
Copy link
Member Author

As discussed with @JonellaCulmer, it is too challenging to put in the filter tag functionality at this point and would likely slow down development if this needed to be implemented in the first iteration. Currently the ADR search is all using input boxes, so it would be easy enough for the user to clear the input box or type something else to do another search.

@patphongs patphongs self-assigned this Oct 19, 2018
@patphongs
Copy link
Member Author

patphongs commented Oct 19, 2018

Outstanding items from design sync:

  • Move datatable counts to below the Alternative dispute resolution heading
  • Add ADR classic info message
  • Add grey dividing lines between table cells

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR/AF pages Implementation of ADR/AF pages on .gov Work: Front-end Work: UX/Design
Projects
None yet
Development

No branches or pull requests

3 participants