-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ADR datatable page #2436
Comments
@JonellaCulmer I've got a couple of questions, we can go over it in design sync too:
|
@JonellaCulmer Do we have this file icon anywhere? |
@lbeaufort It appears that ADR number and ADR respondent is not filterable like it is for MURs? ADR number filter:This should just return ADR # 843: https://fec-dev-api.app.cloud.gov/v1/legal/search?adr_no=843&hits_returned=20&type=adrs&from_hit=0&api_key=DEMO_KEY Similar to how this call returns just MUR # 843: https://fec-dev-api.app.cloud.gov/v1/legal/search?mur_no=843&hits_returned=20&type=murs&from_hit=0&api_key=DEMO_KEY ADR respondent filter:This should just return a few results for respondent keyword "martin": https://fec-dev-api.app.cloud.gov/v1/legal/search?adr_respondents=martin&hits_returned=20&type=adrs&from_hit=0&api_key=DEMO_KEY Similar to how this call returns just respondent keyword "martin": https://fec-dev-api.app.cloud.gov/v1/legal/search?mur_respondents=martin&hits_returned=20&type=murs&from_hit=0&api_key=DEMO_KEY |
@patphongs that’s correct. We’re moving to the more generic ‘case_’... filters. |
@patphongs Here are some answers to your questions. Happy to discuss further during design sync
|
|
As discussed in design sync, I will make the ADRs within this URL path: UPDATE: fec-cms/fec/data/api_caller.py Line 69 in 449436a
|
As discussed with @JonellaCulmer, it is too challenging to put in the filter tag functionality at this point and would likely slow down development if this needed to be implemented in the first iteration. Currently the ADR search is all using input boxes, so it would be easy enough for the user to clear the input box or type something else to do another search. |
Outstanding items from design sync:
|
What we're after: Using the design created below and data moved to the API in 7.2, we want to begin to implement the front-end interface and canonical pages for the ADR pages.
We're basing this first iteration on the MUR pages currently implemented in production. See example linked above.
Updated mockup following conversations during design sync and dev pairing.
Completion criteria:
The text was updated successfully, but these errors were encountered: